[Response Ops][Alerting] Removing diagnostic logging for ES query rule #203328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ymao1
added
Feature:Alerting
release_note:skip
|
Pinging @elastic/response-ops (Team:ResponseOps) |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]
History
cc @ymao1 |
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12249588127 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 10, 2024
elastic#203328) (cherry picked from commit cbee44b)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 10, 2024
…ry rule (#203328) (#203513) # Backport This will backport the following commits from `main` to `8.x`: - [[Response Ops][Alerting] Removing diagnostic logging for ES query rule (#203328)](#203328) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ying Mao","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-10T04:46:21Z","message":"[Response Ops][Alerting] Removing diagnostic logging for ES query rule (#203328)","sha":"cbee44b7f9f8fe2dcee47ee027d8fa0bbeb24ef3","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Alerting","release_note:skip","Team:ResponseOps","v9.0.0","backport:prev-minor","v8.18.0"],"title":"[Response Ops][Alerting] Removing diagnostic logging for ES query rule","number":203328,"url":"https://github.com/elastic/kibana/pull/203328","mergeCommit":{"message":"[Response Ops][Alerting] Removing diagnostic logging for ES query rule (#203328)","sha":"cbee44b7f9f8fe2dcee47ee027d8fa0bbeb24ef3"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203328","number":203328,"mergeCommit":{"message":"[Response Ops][Alerting] Removing diagnostic logging for ES query rule (#203328)","sha":"cbee44b7f9f8fe2dcee47ee027d8fa0bbeb24ef3"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Ying Mao <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #200023
Summary
Removes the logging that was added in #186332. Since deploying that code, we've found that all of the generated logs have been false positives. Furthermore, we have a new lead on why the false alerts have been triggering and it is related more to field caps errors than anything in our rule executor logic (#201266)