Remove deprecated usage of environment
#202124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miloszmarcinkowski
added
release_note:skip
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Page load bundle
|
botelastic
bot
added
ci:project-deploy-observability
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12070832996 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 28, 2024
Closes elastic#200720 ## Summary This PR removes deprecated usage of `environment` property. The code isn't used anymore, therefore can be removed safely. https://github.com/elastic/kibana/blob/d0d33aab38009fe19cb18bacd3bf1943b5a8043f/src/plugins/home/public/plugin.ts#L202-L208 (cherry picked from commit 979f3e8)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 28, 2024
…202183) # Backport This will backport the following commits from `main` to `8.x`: - [Remove deprecated usage of `environment` (#202124)](#202124) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Milosz Marcinkowski","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-28T14:29:54Z","message":"Remove deprecated usage of `environment` (#202124)\n\nCloses #200720\r\n\r\n## Summary\r\n\r\nThis PR removes deprecated usage of `environment` property. The code\r\nisn't used anymore, therefore can be removed safely.\r\n\r\n\r\nhttps://github.com/elastic/kibana/blob/d0d33aab38009fe19cb18bacd3bf1943b5a8043f/src/plugins/home/public/plugin.ts#L202-L208","sha":"979f3e8ac492dd4cb7f77793ae54aa094edf99be","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services"],"title":"Remove deprecated usage of `environment`","number":202124,"url":"https://github.com/elastic/kibana/pull/202124","mergeCommit":{"message":"Remove deprecated usage of `environment` (#202124)\n\nCloses #200720\r\n\r\n## Summary\r\n\r\nThis PR removes deprecated usage of `environment` property. The code\r\nisn't used anymore, therefore can be removed safely.\r\n\r\n\r\nhttps://github.com/elastic/kibana/blob/d0d33aab38009fe19cb18bacd3bf1943b5a8043f/src/plugins/home/public/plugin.ts#L202-L208","sha":"979f3e8ac492dd4cb7f77793ae54aa094edf99be"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202124","number":202124,"mergeCommit":{"message":"Remove deprecated usage of `environment` (#202124)\n\nCloses #200720\r\n\r\n## Summary\r\n\r\nThis PR removes deprecated usage of `environment` property. The code\r\nisn't used anymore, therefore can be removed safely.\r\n\r\n\r\nhttps://github.com/elastic/kibana/blob/d0d33aab38009fe19cb18bacd3bf1943b5a8043f/src/plugins/home/public/plugin.ts#L202-L208","sha":"979f3e8ac492dd4cb7f77793ae54aa094edf99be"}}]}] BACKPORT--> Co-authored-by: Milosz Marcinkowski <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
Closes elastic#200720 ## Summary This PR removes deprecated usage of `environment` property. The code isn't used anymore, therefore can be removed safely. https://github.com/elastic/kibana/blob/d0d33aab38009fe19cb18bacd3bf1943b5a8043f/src/plugins/home/public/plugin.ts#L202-L208
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #200720
Summary
This PR removes deprecated usage of
environmentproperty. The code isn't used anymore, therefore can be removed safely.kibana/src/plugins/home/public/plugin.ts
Lines 202 to 208 in d0d33aa