Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Fix overflowing content in anomalies table cells #20029

Merged

Conversation

peteharverson
Copy link
Contributor

Fixes overflowing content in the Anomalies table cells (Firefox, Edge, IE) by adding the eui-textBreakWord class to the table that was added in elastic/eui#864.

Before (Firefox):
table_wrap_before

After (Firefox):
table_wrap_after_ff

Note Chrome supports word-break: break-word so the content breaks preferentially on words in Chrome (see content in description column), where in FF and IE it falls back to word-break: break-all:
table_wrap_after

Fixes #19948

@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui

Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💔 Build Failed

@peteharverson peteharverson force-pushed the ml-anomalies-table-overflow branch from d8791f5 to 2c491ac Compare June 19, 2018 13:20
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@peteharverson peteharverson merged commit eb45fd1 into elastic:master Jun 19, 2018
@peteharverson peteharverson deleted the ml-anomalies-table-overflow branch June 19, 2018 14:30
peteharverson added a commit to peteharverson/kibana that referenced this pull request Jun 19, 2018
maryia-lapata pushed a commit to maryia-lapata/kibana that referenced this pull request Jun 25, 2018
@sophiec20 sophiec20 added the Feature:Anomaly Detection ML anomaly detection label Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ML] Overlapping labels in anomaly table
4 participants