Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [ResponseOps][MaintenanceWindow] Introduce pagination for MW find API (#197172) #198325

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

…elastic#197172)

Fixes: elastic#193076

This PR introduce pagination for our MW find API.

How to test:

Use postman/insomnia/curl.
Do not forget to add this header: `x-elastic-internal-origin: Kibana`,
because this endpoint in internal.

Basically you need to do something like this:
```
GET http://localhost:5601/top/internal/alerting/rules/maintenance_window/_find?page=3&per_page=3
```

Try different page and per_page combination. Try without them.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit 6645e74)
@kibanamachine kibanamachine merged commit b78ca2b into elastic:8.x Oct 30, 2024
34 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

cc @guskovaue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants