[ResponseOps][Cases] Design Review changes PR 1 #194560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💚 CLA has been signed |
georgianaonoleata1904
changed the title
georgianaonoleata1904
added
Feature:Cases
|
Pinging @elastic/response-ops (Team:ResponseOps) |
|
Pinging @elastic/response-ops-cases (Feature:Cases) |
georgianaonoleata1904
force-pushed
the
design-review-issues-188187
branch
from
c9554b8 to
7f69875
Compare
georgianaonoleata1904
changed the title
adcoelho
added
v9.0.0
backport:prev-minor
adcoelho
approved these changes
Oct 1, 2024
js-jankisalvi
approved these changes
Oct 1, 2024
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
To update your PR or re-run it, just comment with: |
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11139141851 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 2, 2024
Connected to elastic#188187 ## Summary - Field names have been aligned on top to ensure consistency with the fields area on the right <img width="1495" alt="Screenshot 2024-10-01 at 14 30 38" src="https://github.com/user-attachments/assets/51578be1-6cd8-43e0-a800-61e562aa5d77"> - Custom field and template name text size has been reduced to align with the badge  --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 616c6e8)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 2, 2024
) # Backport This will backport the following commits from `main` to `8.x`: - [[ResponseOps][Cases] Design Review changes PR 1 (#194560)](#194560) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Georgiana-Andreea Onoleață","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-02T06:48:15Z","message":"[ResponseOps][Cases] Design Review changes PR 1 (#194560)\n\nConnected to https://github.com/elastic/kibana/issues/188187\r\n\r\n## Summary\r\n\r\n- Field names have been aligned on top to ensure consistency with the\r\nfields area on the right\r\n<img width=\"1495\" alt=\"Screenshot 2024-10-01 at 14 30 38\"\r\nsrc=\"https://github.com/user-attachments/assets/51578be1-6cd8-43e0-a800-61e562aa5d77\">\r\n\r\n- Custom field and template name text size has been reduced to align\r\nwith the badge\r\n\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"616c6e837fedeb5c15d62670c48072c1d6ea542b","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","v9.0.0","Feature:Cases","backport:prev-minor","v8.16.0"],"title":"[ResponseOps][Cases] Design Review changes PR 1","number":194560,"url":"https://github.com/elastic/kibana/pull/194560","mergeCommit":{"message":"[ResponseOps][Cases] Design Review changes PR 1 (#194560)\n\nConnected to https://github.com/elastic/kibana/issues/188187\r\n\r\n## Summary\r\n\r\n- Field names have been aligned on top to ensure consistency with the\r\nfields area on the right\r\n<img width=\"1495\" alt=\"Screenshot 2024-10-01 at 14 30 38\"\r\nsrc=\"https://github.com/user-attachments/assets/51578be1-6cd8-43e0-a800-61e562aa5d77\">\r\n\r\n- Custom field and template name text size has been reduced to align\r\nwith the badge\r\n\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"616c6e837fedeb5c15d62670c48072c1d6ea542b"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194560","number":194560,"mergeCommit":{"message":"[ResponseOps][Cases] Design Review changes PR 1 (#194560)\n\nConnected to https://github.com/elastic/kibana/issues/188187\r\n\r\n## Summary\r\n\r\n- Field names have been aligned on top to ensure consistency with the\r\nfields area on the right\r\n<img width=\"1495\" alt=\"Screenshot 2024-10-01 at 14 30 38\"\r\nsrc=\"https://github.com/user-attachments/assets/51578be1-6cd8-43e0-a800-61e562aa5d77\">\r\n\r\n- Custom field and template name text size has been reduced to align\r\nwith the badge\r\n\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"616c6e837fedeb5c15d62670c48072c1d6ea542b"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Georgiana-Andreea Onoleață <[email protected]>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connected to #188187
Summary