Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set useEcs to true in SLO burn rate rule #194322

Merged
merged 7 commits into from
Oct 1, 2024
Merged

Set useEcs to true in SLO burn rate rule #194322

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3b91761
Set useEcs to true in SLO burn rate rule
maryam-saeidi Sep 27, 2024
719e1ea
Update observability_slo_schema
maryam-saeidi Sep 30, 2024
9a2e3fa
Merge branch 'main' into enable-ecs-for-slo-rule
maryam-saeidi Sep 30, 2024
0ce90f4
Merge branch 'main' into enable-ecs-for-slo-rule
maryam-saeidi Sep 30, 2024
466a4a1
Fix test
maryam-saeidi Sep 30, 2024
8096349
Merge branch 'main' into enable-ecs-for-slo-rule
maryam-saeidi Sep 30, 2024
95a13af
Fix test
maryam-saeidi Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/kbn-alerts-as-data-utils/src/schemas/generated/observability_slo_schema.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
import * as rt from 'io-ts';
import { Either } from 'fp-ts/lib/Either';
import { AlertSchema } from './alert_schema';
import { EcsSchema } from './ecs_schema';
import { LegacyAlertSchema } from './legacy_alert_schema';
const ISO_DATE_PATTERN = /^d{4}-d{2}-d{2}Td{2}:d{2}:d{2}.d{3}Z$/;
export const IsoDateString = new rt.Type<string, string, unknown>(
Expand Down Expand Up @@ -88,6 +89,6 @@ const ObservabilitySloAlertOptional = rt.partial({
});

// prettier-ignore
export const ObservabilitySloAlertSchema = rt.intersection([ObservabilitySloAlertRequired, ObservabilitySloAlertOptional, AlertSchema, LegacyAlertSchema]);
export const ObservabilitySloAlertSchema = rt.intersection([ObservabilitySloAlertRequired, ObservabilitySloAlertOptional, AlertSchema, EcsSchema, LegacyAlertSchema]);
// prettier-ignore
export type ObservabilitySloAlert = rt.TypeOf<typeof ObservabilitySloAlertSchema>;
2 changes: 1 addition & 1 deletion x-pack/plugins/observability_solution/slo/server/lib/rules/slo_burn_rate/register.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ export function sloBurnRateRuleType(
alerts: {
context: SLO_RULE_REGISTRATION_CONTEXT,
mappings: { fieldMap: { ...legacyExperimentalFieldMap, ...sloRuleFieldMap } },
useEcs: false,
useEcs: true,
useLegacyAlerts: true,
shouldWrite: true,
},
Expand Down
4 changes: 2 additions & 2 deletions x-pack/test/api_integration/apis/maps/maps_telemetry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@ export default function ({ getService }: FtrProviderContext) {
return fieldStat.name === 'geo_point';
}
);
expect(geoPointFieldStats.count).to.be(47);
expect(geoPointFieldStats.index_count).to.be(11);
expect(geoPointFieldStats.count).to.be(55);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw a similar change for this value here, @doakalexi can you please help me understand why this change happened when I updated the SLO burn rate rule mapping?

expect(geoPointFieldStats.index_count).to.be(12);

const geoShapeFieldStats = apiResponse.cluster_stats.indices.mappings.field_types.find(
(fieldStat: estypes.ClusterStatsFieldTypes) => {
Expand Down
Loading