[Console] Improve status code highlighting #192888
Conversation
ElenaStoeva
added
Feature:Console
| }, | ||
| }, | ||
| ]; | ||
|
|
||
| expect(getStatusCodeDecorations(SAMPLE_COMPLETE_DATA)).toEqual(EXPECTED_DECORATIONS); | ||
| }); | ||
|
|
||
| it('only returns decorations for data with complete status code and text', () => { |
There was a problem hiding this comment.
Removing this test as now we have a decoration for the first line of every response regardless of the completeness of the status code and text
|
Pinging @elastic/kibana-management (Team:Kibana Management) |
|
@ElenaStoeva did you check the color contrast for these new background colors? |
There was a problem hiding this comment.
Awesome work @ElenaStoeva, looks a loooot better now! Code changes lgtm, although when I was testing I noticed a small problem with the color of the error response.
As already mentioned I think we need to properly asses the colors to make sure they are compliant.
Good call! In fd60c2a I added |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @ElenaStoeva |
Closes #190731
Summary
This PR improves the status code highlighting when multiple requests are sent.
Screen.Recording.2024-09-17.at.12.15.20.mov
Dark mode:
All code statuses:
