Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Obs AI Assistant] remove flaky test #191531

Merged
merged 7 commits into from
Aug 28, 2024

Conversation

neptunian
Copy link
Contributor

@neptunian neptunian commented Aug 27, 2024

This test can be flaky because the "save" button only appears if the there is change in one of the form values, but the change can be "reset" if the state takes a while to load in some edge case so the "save" button does not appear. Given I already added a test for making sure that the inputs are disabled when a user does not have access to Advanced Settings, this test is somewhat redundant in terms of security access and given its flaky nature, I would like to remove it. I could see having it in another test suite that tests general functionality of the settings page and a unit test for useEditableSettings.

Closes #190637

@neptunian neptunian requested a review from a team as a code owner August 27, 2024 17:13
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:Obs AI Assistant Observability AI Assistant labels Aug 27, 2024
@obltmachine
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@neptunian neptunian added the release_note:skip Skip the PR/issue when compiling release notes label Aug 27, 2024
@neptunian
Copy link
Contributor Author

/ci

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#6815

[✅] x-pack/test/observability_ai_assistant_functional/enterprise/config.ts: 25/25 tests passed.

see run history

@neptunian
Copy link
Contributor Author

/ci

@neptunian
Copy link
Contributor Author

/ci

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#6822

[✅] x-pack/test/observability_ai_assistant_functional/enterprise/config.ts: 25/25 tests passed.

see run history

@kibana-ci
Copy link
Collaborator

kibana-ci commented Aug 28, 2024

💚 Build Succeeded

  • Buildkite Build
  • Commit: fe550c2
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-191531-fe550c2db52c

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:Obs AI Assistant Observability AI Assistant v8.16.0
Projects
None yet
5 participants