Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cloud] Extend metadata #189001

Merged
merged 5 commits into from
Jul 24, 2024
Merged

[Cloud] Extend metadata #189001

merged 5 commits into from
Jul 24, 2024

Conversation

afharo
Copy link
Member

@afharo afharo commented Jul 23, 2024

Summary

Related to #188562

We are missing some information that should come in our telemetry and we'd like to use in our feature flag evaluation contexts:

  • Organization ID: The Elastic Cloud Organization that owns the deployment/project
  • Orchestrator Target: On Serverless, whether it's a canary or non-canary project.

This PR adds the config to accept both.

cc @elastic/platform-analytics as there are 2 new fields that will be included in our telemetry:

  • EBT: context.organizationId and context.orchestratorTarget
  • Snapshot telemetry: stack_stats.kibana.plugins.cloud.[organizationId,orchestratorTarget]

Checklist

For maintainers

@afharo afharo added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Jul 23, 2024
@afharo afharo self-assigned this Jul 23, 2024
@afharo afharo requested a review from a team as a code owner July 23, 2024 19:27
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@afharo afharo requested a review from a team as a code owner July 23, 2024 19:31
@afharo afharo requested a review from a team as a code owner July 23, 2024 19:33
@afharo afharo added the Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! label Jul 23, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
cloud 19 20 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
cloud 6.6KB 7.1KB +485.0B
Unknown metric groups

API count

id before after diff
cloud 78 81 +3

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @afharo

Copy link
Contributor

@SiddharthMantri SiddharthMantri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security changes LGTM!

@afharo afharo merged commit 56fc5ce into elastic:main Jul 24, 2024
20 checks passed
@afharo afharo deleted the cloud/extend-metadata branch July 24, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants