remove application icon assets in kibana that ship with EUI #18570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Build Failed |
💚 Build Succeeded |
chrisdavies
approved these changes
May 1, 2018
💔 Build Failed |
|
Logstash pipelines one needs to be updated: Otherwise, lgtm pending passing ci |
💚 Build Succeeded |
nreese
added a commit
to nreese/kibana
that referenced
this pull request
May 7, 2018
…18570) * remove assets in kibana that ship with EUI * update home page tests * replace logstash pipeline svg with EUI icon type
nreese
added a commit
that referenced
this pull request
May 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the home page was first created, EUI did not exist so the app icons where placed in kibana. Now all app icons exist in EUI. This PR is just cleaning up the old icons from kibana.