Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add real provider for i18nProvider mock #181025

Merged

Conversation

pgayvallet
Copy link
Contributor

@pgayvallet pgayvallet commented Apr 17, 2024

Summary

Fix #180725

@pgayvallet
Copy link
Contributor Author

/ci

@pgayvallet
Copy link
Contributor Author

/ci

1 similar comment
@pgayvallet
Copy link
Contributor Author

/ci

@pgayvallet pgayvallet force-pushed the kbn-180725-stubbed-i18n-context-mock branch from 014120d to 7693020 Compare April 18, 2024 07:18
@pgayvallet pgayvallet added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc release_note:skip Skip the PR/issue when compiling release notes v8.14.0 labels Apr 18, 2024
@pgayvallet
Copy link
Contributor Author

/ci

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
@kbn/core-i18n-browser-mocks 0 1 +1

Total ESLint disabled count

id before after diff
@kbn/core-i18n-browser-mocks 0 1 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@pgayvallet pgayvallet marked this pull request as ready for review April 18, 2024 10:55
@pgayvallet pgayvallet requested a review from a team as a code owner April 18, 2024 10:55
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@pgayvallet pgayvallet merged commit 5f0b9f7 into elastic:main Apr 19, 2024
22 checks passed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 19, 2024
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.14

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Apr 19, 2024
# Backport

This will backport the following commits from `main` to `8.14`:
- [Add real provider for i18nProvider mock
(#181025)](#181025)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Pierre
Gayvallet","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-04-19T07:47:43Z","message":"Add
real provider for i18nProvider mock (#181025)\n\n## Summary\r\n\r\nFix
https://github.com/elastic/kibana/issues/180725","sha":"5f0b9f7110ae7b0c3db6409f1074cd458ba9221b","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:skip","v8.14.0","v8.15.0"],"title":"Add
real provider for i18nProvider
mock","number":181025,"url":"https://github.com/elastic/kibana/pull/181025","mergeCommit":{"message":"Add
real provider for i18nProvider mock (#181025)\n\n## Summary\r\n\r\nFix
https://github.com/elastic/kibana/issues/180725","sha":"5f0b9f7110ae7b0c3db6409f1074cd458ba9221b"}},"sourceBranch":"main","suggestedTargetBranches":["8.14"],"targetPullRequestStates":[{"branch":"8.14","label":"v8.14.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/181025","number":181025,"mergeCommit":{"message":"Add
real provider for i18nProvider mock (#181025)\n\n## Summary\r\n\r\nFix
https://github.com/elastic/kibana/issues/180725","sha":"5f0b9f7110ae7b0c3db6409f1074cd458ba9221b"}}]}]
BACKPORT-->

Co-authored-by: Pierre Gayvallet <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.14.0 v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Core/Mocks] i18n service mock should use better mock implementation
5 participants