Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Split functional tests in more groups #180046

Merged
merged 11 commits into from
Apr 24, 2024

Conversation

jughosta
Copy link
Contributor

@jughosta jughosta commented Apr 4, 2024

Summary

This PR splits existing functional tests into more groups so each of them finishes running quicker.

  • group1 into group1 and group5
  • group2 into group2_data_grid1, group2_data_grid2, group2_data_grid3
  • group3 into group3 and group6
  • group4 into group4, group7 and group8 (almost empty)

@jughosta jughosta added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Apr 4, 2024
@jughosta jughosta self-assigned this Apr 4, 2024
@jughosta
Copy link
Contributor Author

jughosta commented Apr 4, 2024

/ci

@jughosta jughosta marked this pull request as ready for review April 4, 2024 16:01
@jughosta jughosta requested review from a team as code owners April 4, 2024 16:01
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

Copy link
Contributor

@davismcphee davismcphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for speeding up our functional test runs! This looks good to me, although I'd like to wait until after #166577 is merged to merge this one since it touches a few different functional tests. Also, do you think we should update the way the copied test_serverless tests are structured to match these new groups?

@jughosta jughosta requested a review from a team April 16, 2024 16:25
@jughosta jughosta requested a review from a team as a code owner April 16, 2024 16:25
- test/functional/apps/discover/group5/config.ts
- test/functional/apps/discover/group6/config.ts
- test/functional/apps/discover/group7/config.ts
- test/functional/apps/discover/group8/config.ts
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, how much quicker is it, generally speaking?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wayneseymour These are the times for the new groups:

Screenshot 2024-04-16 at 19 52 24

https://buildkite.com/elastic/kibana-pull-request/builds/201107#018ea964-5b6b-436c-9b49-b2daf1e30abd

And these tests were inside other groups previously. So it's somewhat around 40-50%.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jughosta

Copy link
Member

@wayneseymour wayneseymour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@davismcphee davismcphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this and updating the serverless tests too! LGTM 👍

@jughosta
Copy link
Contributor Author

Hi @elastic/enterprise-search-frontend team,
Your review was requested automatically for this PR. Could you please have a look?

@jughosta jughosta enabled auto-merge (squash) April 24, 2024 08:19
@jughosta jughosta merged commit ed2f63b into elastic:main Apr 24, 2024
16 checks passed
@jughosta jughosta deleted the split-discover-functional-test-groups branch April 24, 2024 17:23
kpatticha pushed a commit to kpatticha/kibana that referenced this pull request Apr 26, 2024
## Summary

This PR splits existing functional tests into more groups so each of
them finishes running quicker.

- `group1` into `group1` and `group5`
- `group2` into `group2_data_grid1`, `group2_data_grid2`,
`group2_data_grid3`
- `group3` into `group3` and `group6`
- `group4` into `group4`, `group7` and `group8` (almost empty)

---------

Co-authored-by: Davis McPhee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants