-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Discover] Split functional tests in more groups #180046
[Discover] Split functional tests in more groups #180046
Conversation
/ci |
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for speeding up our functional test runs! This looks good to me, although I'd like to wait until after #166577 is merged to merge this one since it touches a few different functional tests. Also, do you think we should update the way the copied test_serverless
tests are structured to match these new groups?
…tional-test-groups
- test/functional/apps/discover/group5/config.ts | ||
- test/functional/apps/discover/group6/config.ts | ||
- test/functional/apps/discover/group7/config.ts | ||
- test/functional/apps/discover/group8/config.ts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious, how much quicker is it, generally speaking?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wayneseymour These are the times for the new groups:

https://buildkite.com/elastic/kibana-pull-request/builds/201107#018ea964-5b6b-436c-9b49-b2daf1e30abd
And these tests were inside other groups previously. So it's somewhat around 40-50%.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @jughosta |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this and updating the serverless tests too! LGTM 👍
Hi @elastic/enterprise-search-frontend team, |
## Summary This PR splits existing functional tests into more groups so each of them finishes running quicker. - `group1` into `group1` and `group5` - `group2` into `group2_data_grid1`, `group2_data_grid2`, `group2_data_grid3` - `group3` into `group3` and `group6` - `group4` into `group4`, `group7` and `group8` (almost empty) --------- Co-authored-by: Davis McPhee <[email protected]>
Summary
This PR splits existing functional tests into more groups so each of them finishes running quicker.
group1
intogroup1
andgroup5
group2
intogroup2_data_grid1
,group2_data_grid2
,group2_data_grid3
group3
intogroup3
andgroup6
group4
intogroup4
,group7
andgroup8
(almost empty)