-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] AIOps: Identify spike/dips with change point detection for log rate analysis #178338
Conversation
295cdd3
to
80cace8
Compare
80cace8
to
1d9d862
Compare
9880442
to
2de7f71
Compare
✅ Flaky Test Runner: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5541 |
Pinging @elastic/ml-ui (:ml) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Import changes LGTM!
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
@peteharverson Good input! I updated the behavior:
Custom prompt when we detect a change point: ![]() Change point highlighting disabled when user selected another time range: ![]() |
@peteharverson thanks for catching that! The brushes not showing up should be fixed now in d8daf32. |
const wpSnap = getSnappedWindowParameters(wp, snapTimestamps); | ||
|
||
if (brushSelectionUpdate !== undefined) { | ||
setInitialAnalysisStart(wpSnap); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be fixed now in d754830, ready for another look!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested latest changes and LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ⚡
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Unknown metric groupsAPI count
History
To update your PR or re-run it, just comment with: cc @walterra |
Summary
Review notes:
obs-ux
team it's just some imports that needed to be updated.Checklist