[Security Solution] Add dataViewId to filter actions #177946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semd
added
bug
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
|
Pinging @elastic/security-threat-hunting-explore (Team:Threat Hunting:Explore) |
|
@elasticmachine merge upstream |
semd
commented
Mar 4, 2024
x-pack/plugins/security_solution/public/common/hooks/use_data_view_id.test.ts
Outdated
Show resolved
Hide resolved
PhilippeOberti
approved these changes
Mar 5, 2024
angorayc
approved these changes
Mar 5, 2024
x-pack/plugins/security_solution/public/common/components/cell_actions/index.test.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/security_solution/public/common/components/cell_actions/index.test.tsx
Outdated
Show resolved
Hide resolved
davismcphee
approved these changes
Mar 5, 2024
stephmilovic
approved these changes
Mar 5, 2024
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Public APIs missing comments
Async chunks
Unknown metric groupsAPI count
References to deprecated APIs
History
To update your PR or re-run it, just comment with: cc @semd |
animehart
approved these changes
Mar 5, 2024
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 6, 2024
## Summary This PR fixes a bug related to the filter edition: elastic#164406 Filter actions were missing the `meta.index` value, which needs to be assigned to the dataView id being used. When the filter is edited, the filter component retrieves the index pattern from the dataView saved object. The `meta.index` value has been added to all the "Filter in/out" actions using the `CellActions` metadata object. Thanks @angorayc for catching this and implementing the fix ### Screenshots Before:  After:  --------- Co-authored-by: Angela Chuang <[email protected]> Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Angela Chuang <[email protected]> (cherry picked from commit 406b24c)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Mar 6, 2024
…#178081) # Backport This will backport the following commits from `main` to `8.13`: - [[Security Solution] Add dataViewId to filter actions (#177946)](#177946) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sergi Massaneda","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-03-06T10:57:41Z","message":"[Security Solution] Add dataViewId to filter actions (#177946)\n\n## Summary\r\n\r\nThis PR fixes a bug related to the filter edition:\r\nhttps://github.com//issues/164406\r\n\r\nFilter actions were missing the `meta.index` value, which needs to be\r\nassigned to the dataView id being used. When the filter is edited, the\r\nfilter component retrieves the index pattern from the dataView saved\r\nobject.\r\n\r\nThe `meta.index` value has been added to all the \"Filter in/out\" actions\r\nusing the `CellActions` metadata object.\r\n\r\nThanks @angorayc for catching this and implementing the fix\r\n\r\n### Screenshots\r\n\r\nBefore:\r\n\r\n\r\n\r\n\r\nAfter:\r\n\r\n\r\n\r\n\r\n---------\r\n\r\nCo-authored-by: Angela Chuang <[email protected]>\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Angela Chuang <[email protected]>","sha":"406b24c6a8758fc82218ad5dbaf048677454d0d9","branchLabelMapping":{"^v8.14.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Team:Threat Hunting","Team:Threat Hunting:Explore","v8.13.0","v8.14.0","v8.12.3"],"title":"[Security Solution] Add dataViewId to filter actions","number":177946,"url":"https://github.com/elastic/kibana/pull/177946","mergeCommit":{"message":"[Security Solution] Add dataViewId to filter actions (#177946)\n\n## Summary\r\n\r\nThis PR fixes a bug related to the filter edition:\r\nhttps://github.com//issues/164406\r\n\r\nFilter actions were missing the `meta.index` value, which needs to be\r\nassigned to the dataView id being used. When the filter is edited, the\r\nfilter component retrieves the index pattern from the dataView saved\r\nobject.\r\n\r\nThe `meta.index` value has been added to all the \"Filter in/out\" actions\r\nusing the `CellActions` metadata object.\r\n\r\nThanks @angorayc for catching this and implementing the fix\r\n\r\n### Screenshots\r\n\r\nBefore:\r\n\r\n\r\n\r\n\r\nAfter:\r\n\r\n\r\n\r\n\r\n---------\r\n\r\nCo-authored-by: Angela Chuang <[email protected]>\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Angela Chuang <[email protected]>","sha":"406b24c6a8758fc82218ad5dbaf048677454d0d9"}},"sourceBranch":"main","suggestedTargetBranches":["8.13","8.12"],"targetPullRequestStates":[{"branch":"8.13","label":"v8.13.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.14.0","branchLabelMappingKey":"^v8.14.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/177946","number":177946,"mergeCommit":{"message":"[Security Solution] Add dataViewId to filter actions (#177946)\n\n## Summary\r\n\r\nThis PR fixes a bug related to the filter edition:\r\nhttps://github.com//issues/164406\r\n\r\nFilter actions were missing the `meta.index` value, which needs to be\r\nassigned to the dataView id being used. When the filter is edited, the\r\nfilter component retrieves the index pattern from the dataView saved\r\nobject.\r\n\r\nThe `meta.index` value has been added to all the \"Filter in/out\" actions\r\nusing the `CellActions` metadata object.\r\n\r\nThanks @angorayc for catching this and implementing the fix\r\n\r\n### Screenshots\r\n\r\nBefore:\r\n\r\n\r\n\r\n\r\nAfter:\r\n\r\n\r\n\r\n\r\n---------\r\n\r\nCo-authored-by: Angela Chuang <[email protected]>\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Angela Chuang <[email protected]>","sha":"406b24c6a8758fc82218ad5dbaf048677454d0d9"}},{"branch":"8.12","label":"v8.12.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: Sergi Massaneda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a bug related to the filter edition:
#164406
Filter actions were missing the
meta.indexvalue, which needs to be assigned to the dataView id being used. When the filter is edited, the filter component retrieves the index pattern from the dataView saved object.The
meta.indexvalue has been added to all the "Filter in/out" actions using theCellActionsmetadata object.Thanks @angorayc for catching this and implementing the fix
Screenshots
Before:
After: