Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Fix edit filters not working #175109

Closed
wants to merge 21 commits into from
Closed

[Security Solution] Fix edit filters not working #175109

wants to merge 21 commits into from

Conversation

angorayc
Copy link
Contributor

@angorayc angorayc commented Jan 18, 2024 •
edited
Loading

Summary

This PR fixes these issues about unable to edit filters:
#164406
#173958

After:

Should be able to edit filters added from Lens Visualizations - legends:

Screen.Recording.2024-01-26.at.21.42.06.mov
Screen.Recording.2024-01-26.at.21.47.38.mov

Should be able to edit filters added from Lens Visualizations - cell actions:

Screen.Recording.2024-01-26.at.21.43.02.mov

Should be able to edit filters added from timeline:

Screen.Recording.2024-01-26.at.21.37.59.mov

Should be able to edit filters added from alerts table

Screen.Recording.2024-01-26.at.21.59.51.mov

Checklist

@angorayc angorayc changed the title add dataViewId to filter add dataViewId to filters Jan 18, 2024
@angorayc angorayc changed the title add dataViewId to filters add dataViewId to filters meta Jan 18, 2024
@angorayc angorayc changed the title add dataViewId to filters meta [Security Solution] Fix edit filters not working Jan 26, 2024
@angorayc angorayc self-assigned this Jan 26, 2024
@angorayc angorayc added Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore v8.12.1 v8.13.0 labels Jan 26, 2024
@angorayc
Copy link
Contributor Author

buildkite test this

@angorayc
Copy link
Contributor Author

/ci

@angorayc
Copy link
Contributor Author

buildkite test this

@angorayc
Copy link
Contributor Author

buildkite test this

@angorayc
Copy link
Contributor Author

buildkite test this

@angorayc
Copy link
Contributor Author

buildkite test this

@angorayc
Copy link
Contributor Author

angorayc commented Feb 2, 2024

buildkite test this

@angorayc
Copy link
Contributor Author

angorayc commented Feb 2, 2024

buildkite test this

@angorayc
Copy link
Contributor Author

angorayc commented Feb 5, 2024

buildkite test this

@angorayc
Copy link
Contributor Author

buildkite test this

@angorayc
Copy link
Contributor Author

buildkite test this

@angorayc
Copy link
Contributor Author

buildkite test this

@angorayc
Copy link
Contributor Author

/ci

@kibana-ci
Copy link
Collaborator

kibana-ci commented Feb 22, 2024 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #91 / dashboard app - group 5 "after all" hook: afterTestSuite.trigger in "dashboard app - group 5"
  • [job] [logs] FTR Configs #91 / dashboard app - group 5 dashboard data-shared attributes "after all" hook: afterTestSuite.trigger for "data-shared-item title should update a saved search when using a custom panel title"
  • [job] [logs] FTR Configs #91 / dashboard app - group 5 dashboard data-shared attributes "after all" hook: afterTestSuite.trigger for "data-shared-item title should update a saved search when using a custom panel title"
  • [job] [logs] FTR Configs #91 / dashboard app - group 5 dashboard data-shared attributes "before all" hook for "should have time picker with data-shared-timefilter-duration"
  • [job] [logs] FTR Configs #91 / dashboard app - group 5 dashboard data-shared attributes "before all" hook for "should have time picker with data-shared-timefilter-duration"
  • [job] [logs] FTR Configs #62 / Journey[ecommerce_dashboard_saved_search_only] Go to Ecommerce Dashboard with Saved Search only
  • [job] [logs] FTR Configs #62 / Journey[ecommerce_dashboard_saved_search_only] Go to Ecommerce Dashboard with Saved Search only
  • [job] [logs] FTR Configs #82 / Journey[ecommerce_dashboard] Go to Ecommerce Dashboard
  • [job] [logs] FTR Configs #82 / Journey[ecommerce_dashboard] Go to Ecommerce Dashboard
  • [job] [logs] FTR Configs #71 / Journey[flight_dashboard] Go to Flights Dashboard
  • [job] [logs] FTR Configs #71 / Journey[flight_dashboard] Go to Flights Dashboard
  • [job] [logs] FTR Configs #2 / Reporting APIs Usage from new jobs posted should handle preserve_layout pdf
  • [job] [logs] FTR Configs #2 / Reporting APIs Usage from new jobs posted should handle preserve_layout pdf

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 5003 5004 +1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/cell-actions 42 44 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cloudSecurityPosture 412.4KB 412.8KB +432.0B
discover 579.6KB 580.0KB +432.0B
kubernetesSecurity 205.1KB 205.3KB +155.0B
securitySolution 11.6MB 11.6MB +3.9KB
timelines 30.2KB 30.4KB +223.0B
total +5.1KB
Unknown metric groups

API count

id before after diff
@kbn/cell-actions 60 62 +2

References to deprecated APIs

id before after diff
securitySolution 532 531 -1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @angorayc

@angorayc angorayc closed this Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@semd semd semd left review comments

Assignees

@angorayc angorayc

Labels
Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team v8.12.1 v8.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@angorayc @kibana-ci @semd @kibanamachine