Update to EUI 0.0.37 and add proper open sans fonts for EUI's K6 theme #17467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded |
|
Updated to EUI 0.0.36 in here as well, which I've verified fixed things. Once tests pass I'll merge. |
snide
changed the title
|
And now updated to EUI 0.0.37... again, ill wait for tests. |
snide
changed the title
💔 Build Failed |
|
jenkins, test this |
💔 Build Failed |
💚 Build Succeeded |
snide
added a commit
to snide/kibana
that referenced
this pull request
Apr 2, 2018
elastic#17467) * update open sans fonts, fix chrome to work with eui k6 theme * update to eui 0.0.37 * update snapshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes elastic/eui#568
cc @jen-huang
EUI's K6 theme was using slightly different font-weights then what Kibana had access to. I went ahead and updated the fonts to the latest version, and added the 600 weight so that it fixes an issue we had with "semi-bold" fonts in EUI + Kibana.
Viewing this PR correctly is dependent upon elastic/eui#596 being merged and released into Kibana. If you want to test it in Kibana, just change a form label from font-weight 500 to 600 in your inspector (this is what the EUI PR does). Example below.