Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Profiling] Stack traces embeddable #173905

Merged
merged 10 commits into from
Jan 3, 2024
Merged

[Profiling] Stack traces embeddable #173905

merged 10 commits into from
Jan 3, 2024

Conversation

cauemarcondes
Copy link
Contributor

@cauemarcondes cauemarcondes commented Dec 22, 2023 •
edited
Loading

Adding Stack traces Threads to the Infra plugin

Screenshot 2023-12-27 at 14 28 50

Error:
Screenshot 2024-01-02 at 10 08 22

Empty:
Screenshot 2024-01-02 at 10 11 01

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@cauemarcondes cauemarcondes marked this pull request as ready for review December 27, 2023 14:33
@cauemarcondes cauemarcondes requested review from a team as code owners December 27, 2023 14:33
MiriamAparicio
MiriamAparicio approved these changes Dec 28, 2023
View reviewed changes
Copy link
Contributor

@MiriamAparicio MiriamAparicio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌟

mykolaharmash
mykolaharmash approved these changes Jan 2, 2024
View reviewed changes
Copy link
Contributor

@mykolaharmash mykolaharmash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ✨ Only left a couple of questions in the comments.

x-pack/plugins/profiling/public/embeddables/stack_traces/stack_traces.tsx
const rangeFromSec = rangeFrom / 1000;
const rangeToSec = rangeTo / 1000;

const state = useAsync(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this component fetches the data itself instead of taking it from the props, does it also handle error and empty states?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added them here: 155b9b0

For now I copied the same components you created on the Infra side. We can improve that later. Maybe it would be a good idea to encapsulate this logic on each Embeddable, so they know how to display data/error/empty states.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you for addressing this!

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
infra 1330 1340 +10
observabilityShared 133 143 +10
profiling 216 222 +6
total +26

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
observabilityShared 303 305 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 1.3MB 1.3MB +1.2KB
profiling 373.7KB 378.1KB +4.4KB
total +5.5KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
observabilityShared 49.6KB 49.9KB +315.0B
profiling 17.4KB 17.9KB +566.0B
total +881.0B
Unknown metric groups

API count

id before after diff
observabilityShared 307 310 +3

async chunk count

id before after diff
profiling 7 9 +2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cauemarcondes cauemarcondes merged commit 50a6930 into elastic:main Jan 3, 2024
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jan 3, 2024
@cauemarcondes cauemarcondes deleted the profiling-threads-embeddable branch January 3, 2024 09:18
jloleysens added a commit that referenced this pull request Jan 4, 2024
@jloleysens
Merge branch 'main' into versioned-router-and-oas
912d763 
* main: (4129 commits)
  [Logs Explorer] Change the default link for "Discover" in the serverless nav (#173420)
  [Fleet] fix unhandled error in agent details when components are missing (#174152)
  [Obs UX] Unskip transaction duration alerts test (#174069)
  [Fleet] Fix keep policies up to date after package install (#174093)
  [Profiling] Stack traces embeddable (#173905)
  [main] Sync bundled packages with Package Storage (#174115)
  [SLO Form] Refactor to use kibana data view component (#173513)
  [Obs UX] Unskip APM Service Inventory Journey (#173510)
  [Obs UX] Unskip preview_chart_error_count test (#173624)
  [api-docs] 2024-01-03 Daily api_docs build (#174142)
  Update babel runtime helpers (#171745)
  Handle content stream errors in report pre-deletion (#173792)
  [Cloud Posture] [Quick wins] Enable edit DataView on the Misconfigurations Findings Table (#173870)
  [ftr] abort retry on invalid webdriver session (#174092)
  Upgrade openai to 4.24.1 (#173934)
  chore(NA): bump node into v20 (#173461)
  [Security Solution][Endpoint] Fix index name pattern in SentinelOne dev. script (#174105)
  fix versions.json
  [Obs AI Assistant] Add guardrails (#174060)
  [ML] Transforms: Refactor validators and add unit tests. (#173736)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mykolaharmash mykolaharmash mykolaharmash approved these changes

@shahzad31 shahzad31 shahzad31 approved these changes

@MiriamAparicio MiriamAparicio MiriamAparicio approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:enhancement v8.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@cauemarcondes @apmmachine @kibana-ci @mykolaharmash @shahzad31 @MiriamAparicio @kibanamachine