Upgrade EUI to v85.1.0 #162660

breehall · 2023-07-27T19:04:44Z

85.0.0 ➡️ 85.1.0

⚠️ The biggest change in this PR by far is the removal of several EuiFilterSelectItem CSS classes and styles associated with those classes. EUI has previously exported component-specific CSS classes for usage such as .euiFilterSelect__items, .euiFilterGroup__popoverPanel, or .euiAccordionForm.

❌ As of our move to CSS-in-JS, we are actively moving away from this architecture. The goal is to either provide either a component or prop directly to you instead of a CSS class. As a reminder, our classNames are not guaranteed APIs and are subject to change without warning - should you need to tweak or customize EUI's styling, we strongly recommend passing in your own className.

💬 Moving forward, EUI will attempted to convert any usages of removed CSS classes and their direct usages in Kibana for you. In most cases, we'll hopefully be able to take the correct path of using a component or prop instead. In cases where we cannot or significant/complex changes are required, we may temporarily convert the CSS to a static CSS-in-JS usage instead and add a TODO asking the relevant team to address this in their own time (for example, the deprecation of EuiFilterSelectItem and its conversion to EuiSelectable).

`85.1.0`

Updated EuiComboBox's options to accept option.append and option.prepend props (#6953)
Updated deprecated .substr() usages to .substring() (#6954)
Updated EuiInlineEdit's read mode button to include a title tooltip, increasing readability of truncated text (#6966)

Bug fixes

Fixed EuiFilterGroup's responsive styles (#6983)

Deprecations

Deprecated EuiFilterSelectItem; Use EuiSelectable instead (#6982)

CSS-in-JS conversions

Converted EuiFilterSelectItem to Emotion (#6982)
Removed .euiFilterSelect__items CSS; Use EuiSelectable instead (#6982)
Removed .euiFilterSelect__note and .euiFilterSelect__noteContent CSS; Use EuiSelectableMessage instead (#6982)
Added focus.transparency and focus.backgroundColor theme tokens (#6984)

- in favor of an actual component

- This CSS is no longer valid as of `EuiFilterSelectItem`'s Emotion conversion, and additionally we strongly recommend devs switch to using `EuiSelectable` as `EuiFilterSelectItem` will be deprecated at some point in the future

Merge main

…e of EUI. This includes the conversion of EuiFilterGroupItem to Emotion and the removal of various euiFilterSelect classes.

elasticmachine · 2023-07-28T20:38:18Z

Pinging @elastic/eui-team (EUI)

elasticmachine · 2023-07-28T21:02:52Z

Pinging @elastic/fleet (Team:Fleet)

walterra

ML related changes LGTM.

peteharverson · 2023-07-31T09:05:49Z

..._visualizer/public/application/common/components/multi_select_picker/multi_select_picker.tsx

-        </p>
-      </div>
-    </div>
+    <EuiSelectableMessage>


@breehall what are the plans for switching out the deprecated EuiFilterSelectItem for EuiSelectable, as is still being used in our file here?

There's a few too many usages in Kibana for EUI to tackle every single one of these ourselves, so we left the inline comments in hopes that Kibana teams would grab the deprecation conversions in their own time. It should hopefully be a fairly straightforward conversion, and if needed you can reference our docs example: https://elastic.github.io/eui/#/forms/filter-group#multi-select

As I mentioned in another comment, the final removal of EuiFilterSelectItem is still 6months+ out, so hopefully plenty of time for y'all - but please let us know if we can be a resource for this!

x-pack/plugins/ml/public/application/components/multi_select_picker/multi_select_picker.tsx

jeramysoucy

Kibana security (Spaces navigation) changes LGTM

alisonelizabeth

I found a small visual regression in Index Management. Please let me know if you need help addressing. Thanks!

...components/component_templates/component_template_selector/components/filter_list_button.tsx

alisonelizabeth · 2023-07-31T15:52:49Z

...components/component_templates/component_template_selector/components/filter_list_button.tsx

@@ -76,7 +83,10 @@ export function FilterListButton({ onChange, filters }: Props) {
        panelPaddingSize="none"
        data-test-subj="filterList"
      >
-        <div className="euiFilterSelect__items">
+        {/* EUI NOTE: Please use EuiSelectable (which already has height/scrolling built in)


Is there an approximate timeline yet for the deprecation of EuiFilterSelectItem?

Apologies for not clarifying this - we're shooting for the end of the 2023, although this isn't a firm timeline on our end and we're super happy to flex/work with Kibana teams on this!

spong

Checked out, tested locally and Security Detection Rules changes (ML Popover) LGTM! 👍

sphilipse

ent-search changes LGTM!

cqliu1

Presentation team changes LGTM 👍

cee-chen · 2023-08-01T15:14:57Z

@elasticmachine merge upstream

alisonelizabeth

Deployment Management changes LGTM

kibana-ci · 2023-08-01T19:47:03Z

💚 Build Succeeded

Buildkite Build
Commit: d3040e3

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`controls`	199.8KB	199.8KB	-83.0B
`dataVisualizer`	605.0KB	604.9KB	-78.0B
`enterpriseSearch`	2.5MB	2.5MB	+148.0B
`fleet`	1012.4KB	1012.8KB	+424.0B
`indexManagement`	523.3KB	523.6KB	+358.0B
`infra`	2.0MB	2.0MB	+166.0B
`securitySolution`	15.6MB	15.6MB	+957.0B
`triggersActionsUi`	1.4MB	1.4MB	+365.0B
`visTypeVega`	1.8MB	1.8MB	+165.0B
total			+2.4KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`kbnUiSharedDeps-css`	294.1KB	293.5KB	-604.0B
`kbnUiSharedDeps-npmDll`	6.0MB	6.0MB	+14.1KB
total			+13.6KB

History

💛 Build #146496 was flaky d20bf4e
💔 Build #146444 failed 94240ae
💔 Build #146414 failed 6ff6f33
💔 Build #146256 failed da39fb7
💔 Build #146251 failed 3c4ca04
💛 Build #145659 was flaky 06a0d50

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cee-chen · 2023-08-01T20:14:28Z

Thanks everyone for your terrific reviews and QA so far! ❤️

Pinging the remaining listed CODEOWNERS: @elastic/kibana-design, @elastic/security-threat-hunting-explore, @elastic/security-detection-engine and @gergoabraham. I'll be asking @elastic/kibana-operations to admin merge this in sometime tomorrow as a heads up.

angorayc

Added #162943 to our todo list.

vitaliidm

Detection Engine area LGTM

breehall added 2 commits July 26, 2023 10:14

Upgrade EUI to version 85.1.0

aa3d143

Upgrade EUI to version 85.1.0

65fe690

breehall added release_note:skip Skip the PR/issue when compiling release notes EUI v8.10.0 labels Jul 27, 2023

cee-chen and others added 4 commits July 27, 2023 12:21

Remove deprecated .euiFilterSearchItem__note classes

6599006

- in favor of an actual component

Remove all instances of .euiFilterSelect__items

841153c

- This CSS is no longer valid as of `EuiFilterSelectItem`'s Emotion conversion, and additionally we strongly recommend devs switch to using `EuiSelectable` as `EuiFilterSelectItem` will be deprecated at some point in the future

Merge branch 'main' of github.com:breehall/kibana into eui/85.1.0

33d7179

Merge main

Update various snapshots to reflect changes made in the latest releas…

06a0d50

…e of EUI. This includes the conversion of EuiFilterGroupItem to Emotion and the removal of various euiFilterSelect classes.

breehall marked this pull request as ready for review July 28, 2023 20:38

breehall requested review from a team as code owners July 28, 2023 20:38

breehall requested a review from a team July 28, 2023 20:38

breehall requested a review from a team as a code owner July 28, 2023 20:38

breehall requested review from joeypoon, gergoabraham and spong July 28, 2023 20:38

jbudz approved these changes Jul 28, 2023

View reviewed changes

botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Jul 28, 2023

juliaElastic approved these changes Jul 31, 2023

View reviewed changes

juliaElastic mentioned this pull request Jul 31, 2023

[Fleet] Replace deprecated EuiFilterSelectItem with EuiSelectable #162766

Closed

walterra approved these changes Jul 31, 2023

View reviewed changes

peteharverson reviewed Jul 31, 2023

View reviewed changes

jeramysoucy approved these changes Jul 31, 2023

View reviewed changes

joeypoon approved these changes Jul 31, 2023

View reviewed changes

alisonelizabeth requested changes Jul 31, 2023

View reviewed changes

spong approved these changes Jul 31, 2023

View reviewed changes

sphilipse approved these changes Jul 31, 2023

View reviewed changes

cqliu1 approved these changes Jul 31, 2023

View reviewed changes

Merge branch 'main' into eui/85.1.0

3c4ca04

This comment was marked as duplicate.

Sign in to view

Merge branch 'main' into eui/85.1.0

da39fb7

This comment was marked as duplicate.

Sign in to view

kibanamachine added 2 commits August 1, 2023 09:22

Merge branch 'main' into eui/85.1.0

6ff6f33

Merge branch 'main' into eui/85.1.0

94240ae

kibanamachine and others added 2 commits August 1, 2023 11:15

Merge branch 'main' into eui/85.1.0

d20bf4e

[PR feedback] Account for EuiFilterButton Emotion conversion

d3040e3

cee-chen requested a review from a team as a code owner August 1, 2023 18:15

alisonelizabeth approved these changes Aug 1, 2023

View reviewed changes

angorayc approved these changes Aug 2, 2023

View reviewed changes

ryankeairns approved these changes Aug 2, 2023

View reviewed changes

vitaliidm approved these changes Aug 3, 2023

View reviewed changes

mistic merged commit 68fec4b into elastic:main Aug 3, 2023

kibanamachine added the backport:skip This commit does not require backporting label Aug 3, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade EUI to v85.1.0 #162660

Upgrade EUI to v85.1.0 #162660

breehall commented Jul 27, 2023 •

edited by cee-chen

Loading

elasticmachine commented Jul 28, 2023

elasticmachine commented Jul 28, 2023

walterra left a comment

peteharverson Jul 31, 2023

cee-chen Aug 1, 2023

jeramysoucy left a comment

alisonelizabeth left a comment

alisonelizabeth Jul 31, 2023

cee-chen Aug 1, 2023

spong left a comment •

edited

Loading

sphilipse left a comment

cqliu1 left a comment

This comment was marked as duplicate.

This comment was marked as duplicate.

cee-chen commented Aug 1, 2023

alisonelizabeth left a comment

kibana-ci commented Aug 1, 2023

cee-chen commented Aug 1, 2023

angorayc left a comment

vitaliidm left a comment

Upgrade EUI to v85.1.0 #162660

Upgrade EUI to v85.1.0 #162660

Conversation

breehall commented Jul 27, 2023 • edited by cee-chen Loading

85.1.0

elasticmachine commented Jul 28, 2023

elasticmachine commented Jul 28, 2023

walterra left a comment

Choose a reason for hiding this comment

peteharverson Jul 31, 2023

Choose a reason for hiding this comment

cee-chen Aug 1, 2023

Choose a reason for hiding this comment

jeramysoucy left a comment

Choose a reason for hiding this comment

alisonelizabeth left a comment

Choose a reason for hiding this comment

alisonelizabeth Jul 31, 2023

Choose a reason for hiding this comment

cee-chen Aug 1, 2023

Choose a reason for hiding this comment

spong left a comment • edited Loading

Choose a reason for hiding this comment

sphilipse left a comment

Choose a reason for hiding this comment

cqliu1 left a comment

Choose a reason for hiding this comment

This comment was marked as duplicate.

This comment was marked as duplicate.

cee-chen commented Aug 1, 2023

alisonelizabeth left a comment

Choose a reason for hiding this comment

kibana-ci commented Aug 1, 2023

💚 Build Succeeded

Metrics [docs]

Async chunks

Page load bundle

History

cee-chen commented Aug 1, 2023

angorayc left a comment

Choose a reason for hiding this comment

vitaliidm left a comment

Choose a reason for hiding this comment

breehall commented Jul 27, 2023 •

edited by cee-chen

Loading

`85.1.0`

spong left a comment •

edited

Loading