[Enterprise Search] Import correct exception identifier #161935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navarone-feekery
added
auto-backport
navarone-feekery
added
the
release_note:skip
sphilipse
approved these changes
Jul 14, 2023
sphilipse
reviewed
Jul 14, 2023
x-pack/plugins/enterprise_search/server/lib/indices/delete_access_control_index.test.ts
Outdated
Show resolved
Hide resolved
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
that referenced
this pull request
Jul 14, 2023
## Summary The access control deletion function was importing the wrong `isIndexNotFoundException` to identify when an index doesn't exist. This would cause index deletion to fail if a search index is missing an access control index. (cherry picked from commit 3077919)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
kibanamachine
added a commit
that referenced
this pull request
Jul 14, 2023
… (#161966) # Backport This will backport the following commits from `main` to `8.9`: - [[Enterprise Search] Import correct exception identifier (#161935)](#161935) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Navarone Feekery","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-07-14T12:53:56Z","message":"[Enterprise Search] Import correct exception identifier (#161935)\n\n## Summary\r\n\r\nThe access control deletion function was importing the wrong\r\n`isIndexNotFoundException` to identify when an index doesn't exist. This\r\nwould cause index deletion to fail if a search index is missing an\r\naccess control index.","sha":"3077919bb85bac809d09d55401289145a7e96284","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","auto-backport","Team:EnterpriseSearch","v8.9.0"],"number":161935,"url":"https://github.com/elastic/kibana/pull/161935","mergeCommit":{"message":"[Enterprise Search] Import correct exception identifier (#161935)\n\n## Summary\r\n\r\nThe access control deletion function was importing the wrong\r\n`isIndexNotFoundException` to identify when an index doesn't exist. This\r\nwould cause index deletion to fail if a search index is missing an\r\naccess control index.","sha":"3077919bb85bac809d09d55401289145a7e96284"}},"sourceBranch":"main","suggestedTargetBranches":["8.9"],"targetPullRequestStates":[{"branch":"8.9","label":"v8.9.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: Navarone Feekery <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The access control deletion function was importing the wrong
isIndexNotFoundExceptionto identify when an index doesn't exist. This would cause index deletion to fail if a search index is missing an access control index.