[Serverless] Add navigation functional tests #161856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to d/2023-07-11-chrome-e2e
Dosant
changed the title
Dosant
changed the title
Dosant
added
Team:SharedUX
…rome-e2e # Conflicts: # x-pack/test_serverless/tsconfig.json
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
Dosant
added
the
release_note:skip
semd
reviewed
Jul 17, 2023
|
|
||
| it('breadcrumbs reflect navigation state', async () => { | ||
| await svlCommonNavigation.breadcrumbs.expectExists(); | ||
| // TODO: use `deepLinkId` instead of `text`, once security deep links are available in @kbn/core-chrome-browser |
There was a problem hiding this comment.
We are already setting the navigationTree, should we do something else?
There was a problem hiding this comment.
This isn't required, but nice to have. For example, observability and search have their deep link ids types in a separate package so that we can use it for type safety and auto complete in different places.
sphilipse
approved these changes
Jul 18, 2023
achyutjhunjhunwala
approved these changes
Jul 18, 2023
sebelga
approved these changes
Jul 18, 2023
x-pack/test_serverless/functional/page_objects/svl_common_navigation.ts
Outdated
Show resolved
Hide resolved
| }, | ||
|
|
||
| // helper to assert that the page did not reload | ||
| async createNoPageReloadCheck() { |
x-pack/test_serverless/functional/test_suites/observability/navigation.ts
Outdated
Show resolved
Hide resolved
…rome-e2e # Conflicts: # x-pack/plugins/serverless_observability/public/components/side_navigation/index.tsx
💚 Build Succeeded
Metrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: cc @Dosant |
kibanamachine
added
v8.10.0
backport:skip
ThomThomson
pushed a commit
to ThomThomson/kibana
that referenced
this pull request
Aug 1, 2023
## Summary close elastic#160011 This PR adds helpers for testing serverless specific navigation. There are helpers for sidenav, breadcrumbs, global search, recent items, logo, checking that no page reload happened during nav. This PR also adds some serverless specific navigation tests. The should serve as a navigation smoke check and testing helpers example. Solution teams can improve them as they see fit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
close #160011
This PR adds helpers for testing serverless specific navigation. There are helpers for sidenav, breadcrumbs, global search, recent items, logo, checking that no page reload happened during nav.
This PR also adds some serverless specific navigation tests. The should serve as a navigation smoke check and testing helpers example. Solution teams can improve them as they see fit.