Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cases] Total users returned by suggested users API #161329

Merged
merged 4 commits into from
Jul 7, 2023
Merged

[Cases] Total users returned by suggested users API #161329

merged 4 commits into from
Jul 7, 2023

Conversation

adcoelho
Copy link
Contributor

@adcoelho adcoelho commented Jul 6, 2023 •
edited
Loading

Connected to #146945

Summary

Description Limit Done? Documented?
Total number of users returned by suggest users API 10 ✅ No (internal)

Checklist

Delete any items that are not applicable to this PR.

@adcoelho adcoelho self-assigned this Jul 6, 2023
@adcoelho adcoelho added release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Cases Cases feature v8.10.0 labels Jul 6, 2023
@adcoelho adcoelho marked this pull request as ready for review July 6, 2023 11:35
@adcoelho adcoelho requested a review from a team as a code owner July 6, 2023 11:35
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops-cases (Feature:Cases)

js-jankisalvi
js-jankisalvi approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@js-jankisalvi js-jankisalvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

cnasikas
cnasikas reviewed Jul 7, 2023
View reviewed changes
Copy link
Member

@cnasikas cnasikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Should we add an integration test to test only one validation scenario?

@adcoelho
Copy link
Contributor Author

adcoelho commented Jul 7, 2023

@cnasikas added the integration test you mentioned in x-pack/test/api_integration/apis/cases/suggest_user_profiles.ts

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
cases 146.1KB 146.4KB +340.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 14 16 +2
securitySolution 408 412 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 15 17 +2
securitySolution 487 491 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @adcoelho

@adcoelho adcoelho merged commit ec6bcd6 into elastic:main Jul 7, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jul 7, 2023
@cnasikas cnasikas mentioned this pull request Jul 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cnasikas cnasikas cnasikas approved these changes

@js-jankisalvi js-jankisalvi js-jankisalvi approved these changes

Assignees

@adcoelho adcoelho

Labels
backport:skip This commit does not require backporting Feature:Cases Cases feature release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@adcoelho @elasticmachine @kibana-ci @cnasikas @js-jankisalvi @kibanamachine