Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Observability] Buffer partial chunks when streaming chat response #160124

Merged
merged 4 commits into from
Jun 21, 2023
Merged

[Observability] Buffer partial chunks when streaming chat response #160124

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4acd989
[Observability] Buffer partial chunks when streaming chat response
dgieselaar Jun 21, 2023
3208f41
Merge branch 'main' of github.com:elastic/kibana into co-pilot-chunking
dgieselaar Jun 21, 2023
d550608
Change delay back to 50
dgieselaar Jun 21, 2023
52b2f4a
Merge branch 'main' into co-pilot-chunking
kibanamachine Jun 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions x-pack/plugins/observability/public/context/co_pilot_context/create_co_pilot_service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@ export function createCoPilotService({ enabled, http }: { enabled: boolean; http

const chunks: CreateChatCompletionResponseChunk[] = [];

let prev: string = '';

function read() {
reader!.read().then(({ done, value }) => {
try {
Expand All @@ -61,10 +63,20 @@ export function createCoPilotService({ enabled, http }: { enabled: boolean; http
return;
}

const lines = decoder
.decode(value)
.trim()
.split('\n')
let lines = (prev + decoder.decode(value)).split('\n');

const lastLine = lines[lines.length - 1];

const isPartialChunk = !!lastLine && lastLine !== 'data: [DONE]';

if (isPartialChunk) {
prev = lastLine;
lines.pop();
} else {
prev = '';
}

lines = lines
.map((str) => str.substr(6))
.filter((str) => !!str && str !== '[DONE]');

Expand Down