-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APM] Update APM general settings #159999
[APM] Update APM general settings #159999
Conversation
Pinging @elastic/apm-ui (Team:APM) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
@@ -77,33 +72,6 @@ export function GeneralSettings() { | |||
|
|||
return ( | |||
<> | |||
<EuiCallOut |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we remove the callout completely or just doing it for serverless?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that all the settings are available through either APM general settings or labs I think we can remove it. However, labs feature is only enabled through a flag, is this an issue @chrisdistasio ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's fine to remove the link. Most apps don't link to advanced settings, so not having a link is not breaking expectations. APM already does more by having the settings co-located in the APM app itself. If we think labs is not discoverable we should fix that by making it easier to find and navigate to.
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
Closes to #159911