Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Update APM general settings #159999

Merged
merged 5 commits into from
Jun 21, 2023

Conversation

gbamparop
Copy link
Contributor

@gbamparop gbamparop commented Jun 20, 2023

  • Removes AWS Lambda Metrics (observability:enableAwsLambdaMetrics) as it's available in labs
  • Removes Infrastructure hosts (view observability:enableInfrastructureHostsView) as it's not related to APM
  • Removes the callout that points to advanced settings
image

Closes to #159911

@gbamparop gbamparop added Team:APM - DEPRECATED Use Team:obs-ux-infra_services. release_note:skip Skip the PR/issue when compiling release notes labels Jun 20, 2023
@gbamparop gbamparop requested a review from a team as a code owner June 20, 2023 12:19
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:APM)

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@@ -77,33 +72,6 @@ export function GeneralSettings() {

return (
<>
<EuiCallOut
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove the callout completely or just doing it for serverless?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that all the settings are available through either APM general settings or labs I think we can remove it. However, labs feature is only enabled through a flag, is this an issue @chrisdistasio ?

Copy link
Member

@sorenlouv sorenlouv Jun 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine to remove the link. Most apps don't link to advanced settings, so not having a link is not breaking expectations. APM already does more by having the settings co-located in the APM app itself. If we think labs is not discoverable we should fix that by making it easier to find and navigate to.

@gbamparop
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.6MB 3.6MB -708.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 13 15 +2
securitySolution 411 415 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 14 16 +2
securitySolution 492 496 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:APM - DEPRECATED Use Team:obs-ux-infra_services. v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants