Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(slo): Show SLI preview chart for custom kql #159713

Merged
merged 7 commits into from
Jun 15, 2023

Conversation

kdelemme
Copy link
Contributor

@kdelemme kdelemme commented Jun 14, 2023

Related to https://github.com/elastic/actionable-observability/issues/42

Summary

This PR introduces a SLI preview chart on the SLO form creation for Custom KQL indicator type.
The goal is to help the user building the right query for its SLO, without having to save and wait for the data to be rolled up.

Description Screenshot
When the indicator is valid, we show the data if any image
When indicator is invalid: we show no chart image
When the data is loading image

@kdelemme kdelemme added release_note:skip Skip the PR/issue when compiling release notes Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.9.0 labels Jun 14, 2023
@kdelemme kdelemme self-assigned this Jun 14, 2023
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@kdelemme kdelemme force-pushed the preview-sli-chart branch from 90c6f2d to 4cee50e Compare June 14, 2023 15:17
@kdelemme kdelemme marked this pull request as ready for review June 14, 2023 15:18
@kdelemme kdelemme requested a review from a team as a code owner June 14, 2023 15:18
@elasticmachine
Copy link
Contributor

Pinging @elastic/actionable-observability (Team: Actionable Observability)

@kdelemme kdelemme force-pushed the preview-sli-chart branch 4 times, most recently from fb58c60 to fc65e1d Compare June 15, 2023 17:15
@kdelemme kdelemme force-pushed the preview-sli-chart branch from e263720 to 1f7b72e Compare June 15, 2023 20:32
Copy link
Member

@simianhacker simianhacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kdelemme kdelemme enabled auto-merge (squash) June 15, 2023 20:51
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
observability 431 434 +3

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/slo-schema 111 115 +4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 1021.5KB 1024.0KB +2.4KB
Unknown metric groups

API count

id before after diff
@kbn/slo-schema 111 115 +4

ESLint disabled line counts

id before after diff
enterpriseSearch 13 15 +2
observability 38 39 +1
securitySolution 411 415 +4
total +7

Total ESLint disabled count

id before after diff
enterpriseSearch 14 16 +2
observability 43 44 +1
securitySolution 494 498 +4
total +7

History

  • 💚 Build #135736 succeeded e263720c60f4f3d5acdd6c0061de44f522ad7c9f
  • 💚 Build #135364 succeeded cdebff6c2d94b340c643e25dcf636223c93df80f
  • 💔 Build #135345 failed 3b3669bc4dfea61f05af13be41a53f81b6cfb79f
  • 💔 Build #135252 failed 4cee50e36631ff222e3ee80f182716fe7c69a32a

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kdelemme

@kdelemme kdelemme merged commit f9d16e1 into elastic:main Jun 15, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jun 15, 2023
@kdelemme kdelemme deleted the preview-sli-chart branch September 14, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants