Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SharedUxChromeNavigation V2] Remove "v1" implementation #158919

Merged
merged 16 commits into from
Jun 6, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,12 @@ export interface ChromeProjectNavigationNode {
icon?: string;
/** Optional children of the navigation node */
children?: ChromeProjectNavigationNode[];
/**
* Temporarilly we allow href to be passed.
* Once all the deeplinks will be exposed in packages we will not allow href anymore
* and force deeplink id to be passed
*/
href?: string;
}

/** @public */
Expand Down
2 changes: 1 addition & 1 deletion packages/kbn-optimizer/limits.yml
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ pageLoadAssetSize:
securitySolution: 66738
serverless: 16573
serverlessObservability: 30000
serverlessSearch: 30000
serverlessSearch: 45934
serverlessSecurity: 66019
sessionView: 77750
share: 71239
Expand Down
15 changes: 14 additions & 1 deletion packages/shared-ux/chrome/navigation/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,20 @@
*/

export { NavigationKibanaProvider, NavigationProvider } from './src/services';
export { Navigation } from './src/ui/navigation';

export { DefaultNavigation, getPresets, Navigation } from './src/ui';

export type {
CloudLinkDefinition,
GroupDefinition,
NavigationGroupPreset,
NavigationTreeDefinition,
NodeDefinition,
ProjectNavigationDefinition,
RecentlyAccessedDefinition,
RootNavigationItemDefinition,
} from './src/ui';

export type {
ChromeNavigation,
ChromeNavigationViewModel,
Expand Down
7 changes: 7 additions & 0 deletions packages/shared-ux/chrome/navigation/mocks/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,10 @@ export {
} from './src/jest';
export { StorybookMock as NavigationStorybookMock } from './src/storybook';
export type { Params as NavigationStorybookParams } from './src/storybook';
export {
defaultNavigationTree,
defaultAnalyticsNavGroup,
defaultDevtoolsNavGroup,
defaultManagementNavGroup,
defaultMlNavGroup,
} from './src/default_navigation.test.helpers';
Loading