Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SecuritySolution] Fix bucket names in legend #156764

Merged
merged 8 commits into from
May 5, 2023
Merged

[SecuritySolution] Fix bucket names in legend #156764

merged 8 commits into from
May 5, 2023

Conversation

angorayc
Copy link
Contributor

@angorayc angorayc commented May 4, 2023 •
edited by kibanamachine
Loading

Summary

issue: #156636

This PR is to fix the bucket name in the legend.
When Stack by @timestamp, the bucket names in the legend were not formatted.
In this PR, it parses it with users' local timezone and formate:

Screenshot 2023-05-05 at 00 01 16

Screen.Recording.2023-05-04.at.23.59.21.mov

@angorayc angorayc added bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore v8.8.0 labels May 4, 2023
@angorayc angorayc self-assigned this May 4, 2023
@angorayc angorayc marked this pull request as ready for review May 5, 2023 00:18
@angorayc angorayc requested a review from a team as a code owner May 5, 2023 00:18
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

PhilippeOberti
PhilippeOberti approved these changes May 5, 2023
View reviewed changes
Copy link
Contributor

@PhilippeOberti PhilippeOberti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, works as expected, code LGTM I pushed a commit with some more types fixes, unit tests and storybook stories as well

@angorayc angorayc enabled auto-merge (squash) May 5, 2023 09:03
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
threatIntelligence 52.3KB 52.8KB +510.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 398 401 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 478 481 +3
total +5

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @angorayc

@angorayc angorayc merged commit f2a268c into elastic:main May 5, 2023
@kibanamachine kibanamachine mentioned this pull request May 5, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 5, 2023
@angorayc
[SecuritySolution] Fix bucket names in legend (elastic#156764)
e2d0520 
## Summary

issue: elastic#156636

This PR is to fix the bucket name in the legend.
When Stack by `@timestamp`, the bucket names in the legend were not
formatted.
In this PR, it parses it with users' `local` timezone and formate:

<img width="2549" alt="Screenshot 2023-05-05 at 00 01 16"
src="https://user-images.githubusercontent.com/6295984/236348010-6ebfae4f-6f0e-4e33-9f06-ebc887adb108.png">

https://user-images.githubusercontent.com/6295984/236355789-3438ad32-fb4f-4270-8b4e-11c56b1b5d02.mov

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: PhilippeOberti <[email protected]>
(cherry picked from commit f2a268c)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request May 5, 2023
@kibanamachine @angorayc
[8.8] [SecuritySolution] Fix bucket names in legend (#156764) (#156817)
2d995ee 
# Backport

This will backport the following commits from `main` to `8.8`:
- [[SecuritySolution] Fix bucket names in legend
(#156764)](#156764)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Angela
Chuang","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-05-05T10:01:02Z","message":"[SecuritySolution]
Fix bucket names in legend (#156764)\n\n## Summary\r\n\r\nissue:
https://github.com/elastic/kibana/issues/156636\r\n\r\nThis PR is to fix
the bucket name in the legend.\r\nWhen Stack by `@timestamp`, the bucket
names in the legend were not\r\nformatted.\r\nIn this PR, it parses it
with users' `local` timezone and formate:\r\n\r\n<img width=\"2549\"
alt=\"Screenshot 2023-05-05 at 00 01
16\"\r\nsrc=\"https://user-images.githubusercontent.com/6295984/236348010-6ebfae4f-6f0e-4e33-9f06-ebc887adb108.png\">\r\n\r\n\r\n\r\n\r\n\r\nhttps://user-images.githubusercontent.com/6295984/236355789-3438ad32-fb4f-4270-8b4e-11c56b1b5d02.mov\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>\r\nCo-authored-by:
PhilippeOberti
<[email protected]>","sha":"f2a268cc295b0a7676126ca22c29cee979905b8c","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:Threat
Hunting","Team: SecuritySolution","Team:Threat
Hunting:Explore","v8.8.0","v8.9.0"],"number":156764,"url":"https://github.com/elastic/kibana/pull/156764","mergeCommit":{"message":"[SecuritySolution]
Fix bucket names in legend (#156764)\n\n## Summary\r\n\r\nissue:
https://github.com/elastic/kibana/issues/156636\r\n\r\nThis PR is to fix
the bucket name in the legend.\r\nWhen Stack by `@timestamp`, the bucket
names in the legend were not\r\nformatted.\r\nIn this PR, it parses it
with users' `local` timezone and formate:\r\n\r\n<img width=\"2549\"
alt=\"Screenshot 2023-05-05 at 00 01
16\"\r\nsrc=\"https://user-images.githubusercontent.com/6295984/236348010-6ebfae4f-6f0e-4e33-9f06-ebc887adb108.png\">\r\n\r\n\r\n\r\n\r\n\r\nhttps://user-images.githubusercontent.com/6295984/236355789-3438ad32-fb4f-4270-8b4e-11c56b1b5d02.mov\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>\r\nCo-authored-by:
PhilippeOberti
<[email protected]>","sha":"f2a268cc295b0a7676126ca22c29cee979905b8c"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156764","number":156764,"mergeCommit":{"message":"[SecuritySolution]
Fix bucket names in legend (#156764)\n\n## Summary\r\n\r\nissue:
https://github.com/elastic/kibana/issues/156636\r\n\r\nThis PR is to fix
the bucket name in the legend.\r\nWhen Stack by `@timestamp`, the bucket
names in the legend were not\r\nformatted.\r\nIn this PR, it parses it
with users' `local` timezone and formate:\r\n\r\n<img width=\"2549\"
alt=\"Screenshot 2023-05-05 at 00 01
16\"\r\nsrc=\"https://user-images.githubusercontent.com/6295984/236348010-6ebfae4f-6f0e-4e33-9f06-ebc887adb108.png\">\r\n\r\n\r\n\r\n\r\n\r\nhttps://user-images.githubusercontent.com/6295984/236355789-3438ad32-fb4f-4270-8b4e-11c56b1b5d02.mov\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>\r\nCo-authored-by:
PhilippeOberti
<[email protected]>","sha":"f2a268cc295b0a7676126ca22c29cee979905b8c"}}]}]
BACKPORT-->

Co-authored-by: Angela Chuang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilippeOberti PhilippeOberti PhilippeOberti approved these changes

Assignees

@angorayc angorayc

Labels
bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team v8.8.0 v8.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@angorayc @elasticmachine @kibana-ci @kibanamachine @PhilippeOberti