Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Unified search] Fixes the css priority order for the filter pills #156639

Merged
merged 3 commits into from
May 5, 2023
Merged

[Unified search] Fixes the css priority order for the filter pills #156639

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b022264
[Unified search] Fixes the css order for the filter pills
stratoula May 4, 2023
1b1ed7c
Fix check
stratoula May 4, 2023
484f11d
Remove unused italic css property
stratoula May 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/plugins/unified_search/public/filter_bar/filter_item/filter_item.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* 1. Allow wrapping of long filter items
*/

.globalFilterItem {
.euiBadge.globalFilterItem {
line-height: $euiSize;
border: none;
color: $euiTextColor;
Expand All @@ -18,15 +18,15 @@
}
}

.globalFilterItem-isDisabled {
.euiBadge.globalFilterItem-isDisabled {
color: $euiColorDarkShade;
background-color: transparentize($euiColorLightShade, .5);
text-decoration: line-through;
font-weight: $euiFontWeightRegular;
font-style: italic;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't see where this was actually showing the italic font (before or after this pr). Is it worth removing with this PR since it's touching these classes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanx @mdefazio, done 484f11d

}

.globalFilterItem-isError, .globalFilterItem-isWarning {
.euiBadge.globalFilterItem-isError, .globalFilterItem-isWarning {
.globalFilterLabel__value {
font-weight: $euiFontWeightBold;
}
Expand Down