-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Chrome] Expose api to to set custom component for project left nav #156205
Conversation
packages/core/chrome/core-chrome-browser-internal/src/chrome_service.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea of exposing setNavigation
and setNavigationComponent
. Consumers must call setNavigation
with a configuration that defines the nav tree, and other settings for parts of the chrome that deal with navigation info: breadcrumbs, recent items, global search. Calling setNavigationComponent
is optional - if consumers don't set that, we will render the SharedUX component.
937b318
to
dcfd0b6
Compare
Pinging @elastic/appex-sharedux (Team:SharedUX) |
Thanks for the review @Dosant and @tsullivan ! I addressed your feedback, can you have another look? @tsullivan : This first PR is really only to unblock teams that need to set custom react component for the serveless project left navigation. In future PR I will improve the interface for the navigation config and add everything that the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Page load bundle
Unknown metric groupsAPI count
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @sebelga |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
In this PR I've exposed a new api from the Chrome service to set a custom React component for the side navigation.
Calling this API does not have any effect if Kibana is not started in "project" ChromeStyle.
Api
Example