-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cases ]Expose the bulk get cases API from the cases UI client #154235
Conversation
Pinging @elastic/response-ops-cases (Feature:Cases) |
Pinging @elastic/response-ops (Team:ResponseOps) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought the alerts table was already using this API? How were they using it if we weren't exposing it? Or was it through the backend?
} | ||
); | ||
|
||
return res; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to convert to camel case and decode it to ensure it's in the correct format?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought it would be a good time to break this pattern. Do you think I should camelcase the response? I forgot about the decoding. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love the idea of not doing the camel case conversion anymore haha. Yeah let's not do it anymore. I think I saw you already had an issue to remove the others right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Yes this one here #152706.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed c791b6c
This is for o11y. The alerts table cannot use the cases client as cases depend on the alerts table and it will create a circular dependency. Ideally, we should export our APIs to a package so both of them can access them. |
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Page load bundle
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @cnasikas |
Summary
This PR exposes the bulk get cases API from the cases UI client.
Fixes: #153926
Checklist
Delete any items that are not applicable to this PR.
For maintainers