Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cases ]Expose the bulk get cases API from the cases UI client #154235

Merged
merged 3 commits into from
Apr 4, 2023

Conversation

cnasikas
Copy link
Member

@cnasikas cnasikas commented Apr 3, 2023

Summary

This PR exposes the bulk get cases API from the cases UI client.

Fixes: #153926

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@cnasikas cnasikas added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Cases Cases feature labels Apr 3, 2023
@cnasikas cnasikas self-assigned this Apr 3, 2023
@cnasikas cnasikas requested a review from a team as a code owner April 3, 2023 12:38
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops-cases (Feature:Cases)

@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@cnasikas cnasikas added the release_note:skip Skip the PR/issue when compiling release notes label Apr 3, 2023
Copy link
Contributor

@jonathan-buttner jonathan-buttner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought the alerts table was already using this API? How were they using it if we weren't exposing it? Or was it through the backend?

}
);

return res;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to convert to camel case and decode it to ensure it's in the correct format?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it would be a good time to break this pattern. Do you think I should camelcase the response? I forgot about the decoding. Thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the idea of not doing the camel case conversion anymore haha. Yeah let's not do it anymore. I think I saw you already had an issue to remove the others right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Yes this one here #152706.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed c791b6c

@cnasikas
Copy link
Member Author

cnasikas commented Apr 3, 2023

I thought the alerts table was already using this API? How were they using it if we weren't exposing it? Or was it through the backend?

This is for o11y. The alerts table cannot use the cases client as cases depend on the alerts table and it will create a circular dependency. Ideally, we should export our APIs to a package so both of them can access them.

@cnasikas
Copy link
Member Author

cnasikas commented Apr 3, 2023

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
cases 132.6KB 133.6KB +1020.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 432 435 +3

Total ESLint disabled count

id before after diff
securitySolution 512 515 +3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @cnasikas

@cnasikas cnasikas merged commit 4cd0460 into elastic:main Apr 4, 2023
@cnasikas cnasikas deleted the expose_bulk_api branch April 4, 2023 12:24
@kibanamachine kibanamachine added v8.8.0 backport:skip This commit does not require backporting labels Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Cases Cases feature release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Cases] Export bulk get API from the Cases UI client
7 participants