Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cloud Security] fixed onboarding link directs to cspm integration #153268

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

kfirpeled
Copy link
Contributor

Summary

Updates onboarding link of CSPM to direct to CSPM integration instead of Cloud Security which includes kspm.
The button text is: Secure my cloud assets with {lineBreak} cloud security posture management (CSPM). Therefore it makes more sense to open the CSPM integration directly.

@kfirpeled kfirpeled added release_note:skip Skip the PR/issue when compiling release notes Team:Journey/Onboarding Platform Journey Onboarding team v8.7.0 v8.8.0 labels Mar 17, 2023
@kfirpeled kfirpeled requested a review from a team as a code owner March 17, 2023 22:12
@elasticmachine
Copy link
Contributor

Pinging @elastic/platform-onboarding (Team:Journey/Onboarding)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
home 153.9KB 153.9KB +17.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 433 436 +3

Total ESLint disabled count

id before after diff
securitySolution 513 516 +3

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@alisonelizabeth alisonelizabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM.

Note: It may be worth adding a comment to the 8.7 stack release dev issue since this is getting merged so late in the release cycle (looks like only 1 more BC planned).

@kfirpeled kfirpeled removed the v8.7.0 label Mar 20, 2023
@kfirpeled
Copy link
Contributor Author

Thanks @alisonelizabeth , in that case I'll backport that on the next patch release of 8.7
I've removed 8.7 label

@kfirpeled kfirpeled merged commit 2b5c537 into elastic:main Mar 20, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Mar 20, 2023
v1v added a commit to v1v/kibana that referenced this pull request Mar 20, 2023
…loy-my-kibana-oblt

* upstream/main: (727 commits)
  Upgrade caniuse-lite db (elastic#153318)
  [Security Solution] expanded flyout - right section - json tab implementation (elastic#152935)
  chore(slo): Make APM indicator's index required (elastic#153311)
  skip failing test suite (elastic#136688)
  [Security Solution] Fix security-solution storybook package codeowners (elastic#153307)
  [EUI] Add `scrollLock` workaround CSS to Kibana's `body` (elastic#153227)
  [Cloud Security] Show coming soon deployments of vulnerability management (elastic#153249)
  [Cloud Security] fixed onboarding link directs to cspm integration (elastic#153268)
  [Response Ops][Alerting] Reusable functions for FAAD resource installation (elastic#152849)
  remove geohash_grid aggregation support (elastic#152952)
  [Tech Debt] Reorder Rules page (elastic#152897)
  [Saved Object Finder] Add help text & left button (elastic#152742)
  [Transform] Replace SavedObjectsFinder component (elastic#153128)
  Make pipeline creation endpoint accept a full pipeline definition (elastic#153133)
  [Fleet] Displaying policy changes in Agent activity (elastic#153237)
  skip flaky suite (elastic#152852)
  [Security Solution][Endpoint] Add tests to cover RBAC entries in the Role Kibana Privileges flyout (elastic#153068)
  [Security Solution][Endpoint] Additional tests for Response Console History Log page (covers TestRail manual tests) (elastic#153042)
  [Monitoring] Display node roles in Nodes table (elastic#152127)
  Rename getEditAlertFlyout to getEditRuleFlyout (elastic#153243)
  ...
@kfirpeled kfirpeled added v8.7.1 auto-backport Deprecated - use backport:version if exact versions are needed backport missing Added to PRs automatically when the are determined to be missing a backport. and removed backport:skip This commit does not require backporting labels Apr 2, 2023
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.7

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

kibanamachine pushed a commit that referenced this pull request Apr 2, 2023
@kfirpeled kfirpeled removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 2, 2023
kibanamachine added a commit that referenced this pull request Apr 2, 2023
…ion (#153268) (#154205)

# Backport

This will backport the following commits from `main` to `8.7`:
- [[Cloud Security] fixed onboarding link directs to cspm integration
(#153268)](#153268)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Kfir
Peled","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-03-20T16:53:49Z","message":"[Cloud
Security] fixed onboarding link directs to cspm integration
(#153268)","sha":"2b5c537e117fe488da85603baf4526e9abadbe87","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","auto-backport","Team:Journey/Onboarding","v8.8.0","v8.7.1"],"number":153268,"url":"https://github.com/elastic/kibana/pull/153268","mergeCommit":{"message":"[Cloud
Security] fixed onboarding link directs to cspm integration
(#153268)","sha":"2b5c537e117fe488da85603baf4526e9abadbe87"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/153268","number":153268,"mergeCommit":{"message":"[Cloud
Security] fixed onboarding link directs to cspm integration
(#153268)","sha":"2b5c537e117fe488da85603baf4526e9abadbe87"}},{"branch":"8.7","label":"v8.7.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Kfir Peled <[email protected]>
@kfirpeled kfirpeled self-assigned this Apr 16, 2023
@kfirpeled kfirpeled deleted the cspm/update_onboarding_link branch May 15, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Journey/Onboarding Platform Journey Onboarding team v8.7.1 v8.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants