Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enterprise Search] fix: search experiences plugin name #150945

Conversation

TattdCodeMonkey
Copy link
Contributor

@TattdCodeMonkey TattdCodeMonkey commented Feb 10, 2023

Summary

Updated the Search experiences navigation shortcut to be "Search Experiences" instead of "Enterprise Search"

Screenshot

image

@TattdCodeMonkey
Copy link
Contributor Author

@joemcelroy @julianrosado do you think the "experiences" should be capitalized? I matched the other label but seeing it in the menu gives me second thoughts

@TattdCodeMonkey TattdCodeMonkey force-pushed the rnorris/fix/search-exp-product-name-label branch from 20fa157 to 9ceaefe Compare February 10, 2023 21:21
@TattdCodeMonkey TattdCodeMonkey force-pushed the rnorris/fix/search-exp-product-name-label branch from 9ceaefe to be42670 Compare February 10, 2023 22:05
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
enterpriseSearch 29.9KB 29.9KB +1.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@TattdCodeMonkey TattdCodeMonkey merged commit f5eab68 into elastic:main Feb 14, 2023
@TattdCodeMonkey TattdCodeMonkey deleted the rnorris/fix/search-exp-product-name-label branch February 14, 2023 17:22
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 14, 2023
## Summary

Updated the Search experiences navigation shortcut to be "Search
Experiences" instead of "Enterprise Search"

### Screenshot

![image](https://user-images.githubusercontent.com/1972968/218199866-6a78a1e8-861f-4ca7-9c8f-6e514642ec52.png)

(cherry picked from commit f5eab68)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.7

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Feb 14, 2023
… (#151185)

# Backport

This will backport the following commits from `main` to `8.7`:
- [[Enterprise Search] fix: search experiences plugin name
(#150945)](#150945)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Rodney
Norris","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-02-14T17:21:58Z","message":"[Enterprise
Search] fix: search experiences plugin name (#150945)\n\n##
Summary\r\n\r\nUpdated the Search experiences navigation shortcut to be
\"Search\r\nExperiences\" instead of \"Enterprise Search\"\r\n\r\n###
Screenshot\r\n\r\n![image](https://user-images.githubusercontent.com/1972968/218199866-6a78a1e8-861f-4ca7-9c8f-6e514642ec52.png)","sha":"f5eab68998c54f31a62deb141f2490a1772d8586","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:EnterpriseSearch","v8.7.0","v8.8.0"],"number":150945,"url":"https://github.com/elastic/kibana/pull/150945","mergeCommit":{"message":"[Enterprise
Search] fix: search experiences plugin name (#150945)\n\n##
Summary\r\n\r\nUpdated the Search experiences navigation shortcut to be
\"Search\r\nExperiences\" instead of \"Enterprise Search\"\r\n\r\n###
Screenshot\r\n\r\n![image](https://user-images.githubusercontent.com/1972968/218199866-6a78a1e8-861f-4ca7-9c8f-6e514642ec52.png)","sha":"f5eab68998c54f31a62deb141f2490a1772d8586"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/150945","number":150945,"mergeCommit":{"message":"[Enterprise
Search] fix: search experiences plugin name (#150945)\n\n##
Summary\r\n\r\nUpdated the Search experiences navigation shortcut to be
\"Search\r\nExperiences\" instead of \"Enterprise Search\"\r\n\r\n###
Screenshot\r\n\r\n![image](https://user-images.githubusercontent.com/1972968/218199866-6a78a1e8-861f-4ca7-9c8f-6e514642ec52.png)","sha":"f5eab68998c54f31a62deb141f2490a1772d8586"}}]}]
BACKPORT-->

Co-authored-by: Rodney Norris <[email protected]>
justinkambic pushed a commit to justinkambic/kibana that referenced this pull request Feb 23, 2023
## Summary

Updated the Search experiences navigation shortcut to be "Search
Experiences" instead of "Enterprise Search"

### Screenshot

![image](https://user-images.githubusercontent.com/1972968/218199866-6a78a1e8-861f-4ca7-9c8f-6e514642ec52.png)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants