Updated kbnIndex.indices function to address Non-UTC users #1488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Addresses issue #1487 |
|
Currently breaks the histogram. Will update shortly with a fix and check against anything using the utc function of moment.js. |
|
Issues with original PR. Working on a new version that does not include the issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated kbnIndex.indices function to have a configuration option of utc_tz.
This option is a bool to determine if the user wishes to use UTC or local time when building a list of possible indexes based on the timestamp pattern on the index. This is extremely important for users who are implementing solutions that by their nature use local time and not UTC.