-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Fix Rules and Connectors app labels #145660
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation preview: |
3 tasks
Pinging @elastic/kibana-docs (Team:Docs) |
szabosteve
approved these changes
Nov 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 22, 2022
(cherry picked from commit 8086e99)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 22, 2022
# Backport This will backport the following commits from `main` to `8.6`: - [[DOCS] Fix Rules and Connectors app labels (#145660)](#145660) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Lisa Cawley","email":"[email protected]"},"sourceCommit":{"committedDate":"2022-11-22T17:14:31Z","message":"[DOCS] Fix Rules and Connectors app labels (#145660)","sha":"8086e99478920df7d6230016364fe2df13cd03d6","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Docs","release_note:skip","docs","Feature:Alerting/RulesManagement","v8.6.0","v8.7.0"],"number":145660,"url":"https://github.com/elastic/kibana/pull/145660","mergeCommit":{"message":"[DOCS] Fix Rules and Connectors app labels (#145660)","sha":"8086e99478920df7d6230016364fe2df13cd03d6"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/145660","number":145660,"mergeCommit":{"message":"[DOCS] Fix Rules and Connectors app labels (#145660)","sha":"8086e99478920df7d6230016364fe2df13cd03d6"}}]}] BACKPORT--> Co-authored-by: Lisa Cawley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
docs
Feature:Alerting/RulesManagement
Issues related to the Rules Management UX
release_note:skip
Skip the PR/issue when compiling release notes
Team:Docs
v8.6.0
v8.7.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Relates to #143809
This PR updates the documentation to use the appropriate "Rules" or "Connectors" app name, now that there's no longer a "Rules and Connectors" app. It uses attributes from https://github.com/elastic/docs/blob/master/shared/attributes.asciidoc in case the names change again in the future. It also includes some minor edits on the pages.