Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skip src/core/server/integration_tests/ui_settings/jest.integration.config.js #145646

Merged
merged 1 commit into from
Nov 18, 2022
Merged

skip src/core/server/integration_tests/ui_settings/jest.integration.config.js #145646

merged 1 commit into from
Nov 18, 2022

Conversation

jbudz
Copy link
Member

@jbudz jbudz commented Nov 17, 2022

@jbudz jbudz added Team:Operations Team label for Operations Team release_note:skip Skip the PR/issue when compiling release notes labels Nov 17, 2022
@jbudz jbudz marked this pull request as ready for review November 17, 2022 23:30
@jbudz jbudz requested a review from a team as a code owner November 17, 2022 23:30
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@jbudz
Copy link
Member Author

jbudz commented Nov 17, 2022

skip config looks correct: https://buildkite.com/elastic/kibana-pull-request/builds/89064#018487d7-3fe8-4df4-a997-aa34d8cd5eb4/144-1343

spalger
spalger approved these changes Nov 17, 2022
View reviewed changes
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though please work up an issue for the core team (example) and link it to #141477

@jbudz
Copy link
Member Author

jbudz commented Nov 17, 2022

Opened #145652

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 59 65 +6
osquery 108 113 +5
securitySolution 442 448 +6
total +19

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 67 73 +6
osquery 109 115 +6
securitySolution 519 525 +6
total +20

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jbudz jbudz merged commit 64bae2e into elastic:main Nov 18, 2022
@kibanamachine kibanamachine added v8.7.0 backport:skip This commit does not require backporting labels Nov 18, 2022
jbudz added a commit that referenced this pull request Nov 18, 2022
@jbudz
skip src/core/server/integration_tests/ui_settings/jest.integration.c…
9bb90c3 
…onfig.js (#145646)

This suite has become flaky:

https://buildkite.com/elastic/kibana-on-merge/builds/23746#01848784-7e14-4800-b63a-bfc5905864d7/3656-4619
https://buildkite.com/elastic/kibana-on-merge/builds/23745#01848782-d6ff-42f5-a111-6f2608db2c47/2443-3188
@jbudz jbudz mentioned this pull request Nov 18, 2022
Merged
@jbudz jbudz added v8.6.0 backported and removed backport:skip This commit does not require backporting labels Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spalger spalger spalger approved these changes

Assignees
No one assigned
Labels
backported release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v8.6.0 v8.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jbudz @elasticmachine @kibana-ci @spalger @kibanamachine