Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RAM] Clone rule #144741

Merged
merged 16 commits into from
Nov 15, 2022
Merged

[RAM] Clone rule #144741

merged 16 commits into from
Nov 15, 2022

Conversation

XavierM
Copy link
Contributor

@XavierM XavierM commented Nov 7, 2022

Summary

Allow to clone rule in the rule list table

duplicate

Checklist

@XavierM XavierM added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) ci:cloud-deploy Create or update a Cloud deployment v8.6.0 labels Nov 7, 2022
@XavierM XavierM requested a review from a team as a code owner November 7, 2022 19:37
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@lcawl lcawl added the ui-copy Review of UI copy with docs team is recommended label Nov 9, 2022
Copy link
Contributor

@jcger jcger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally, couldn't break it. Just the error message when something fails 👏

@EricDavisX
Copy link
Contributor

Does this have any risk per rule type - I would love a quick discourse over how it is or is not risky in that regard, and how we're covering it in tests.

I see a few test sections that I can read though, so thank you. One test notably cites this isn't exposed for Security Rules, are there any other 'spec' items we can itemize? @XavierM

@XavierM
Copy link
Contributor Author

XavierM commented Nov 14, 2022

Does this have any risk per rule type - I would love a quick discourse over how it is or is not risky in that regard, and how we're covering it in tests.

I see a few test sections that I can read though, so thank you. One test notably cites this isn't exposed for Security Rules, are there any other 'spec' items we can itemize? @XavierM

I will think this feature is not risky at all because it is like creating a rule. We are not doing it for Security Rules because they have some magic sauce in their own API to migrate some legacy actions and since I do not know what is the magic sauce, I just excluded them. Also this API is an internal API, and we will keep it internal until we have the three solution using it.

We have unit test + api integration to make sure everything is working as expected.

@XavierM XavierM enabled auto-merge (squash) November 14, 2022 21:19
@XavierM
Copy link
Contributor Author

XavierM commented Nov 15, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

kibana-ci commented Nov 15, 2022

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
triggersActionsUi 461 462 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
triggersActionsUi 665.6KB 666.6KB +998.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
triggersActionsUi 104.0KB 104.2KB +160.0B
Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 59 65 +6
osquery 108 113 +5
securitySolution 441 447 +6
total +19

References to deprecated APIs

id before after diff
alerting 96 93 -3

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 67 73 +6
osquery 109 115 +6
securitySolution 518 524 +6
total +20

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@XavierM XavierM merged commit 9cd5c0d into elastic:main Nov 15, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Nov 15, 2022
@XavierM XavierM changed the title [RAM] Duplicate rule [RAM] Clone rule Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting ci:cloud-deploy Create or update a Cloud deployment release_note:enhancement Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) ui-copy Review of UI copy with docs team is recommended v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants