-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RAM] Clone rule #144741
[RAM] Clone rule #144741
Conversation
Pinging @elastic/response-ops (Team:ResponseOps) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested locally, couldn't break it. Just the error message when something fails 👏
...gers_actions_ui/public/application/sections/rules_list/components/collapsed_item_actions.tsx
Outdated
Show resolved
Hide resolved
...plugins/triggers_actions_ui/public/application/sections/rules_list/components/rules_list.tsx
Outdated
Show resolved
Hide resolved
...gers_actions_ui/public/application/sections/rules_list/components/collapsed_item_actions.tsx
Outdated
Show resolved
Hide resolved
Does this have any risk per rule type - I would love a quick discourse over how it is or is not risky in that regard, and how we're covering it in tests. I see a few test sections that I can read though, so thank you. One test notably cites this isn't exposed for Security Rules, are there any other 'spec' items we can itemize? @XavierM |
...gers_actions_ui/public/application/sections/rules_list/components/collapsed_item_actions.tsx
Outdated
Show resolved
Hide resolved
I will think this feature is not risky at all because it is like creating a rule. We are not doing it for Security Rules because they have some magic sauce in their own API to migrate some legacy actions and since I do not know what is the magic sauce, I just excluded them. Also this API is an internal API, and we will keep it internal until we have the three solution using it. We have unit test + api integration to make sure everything is working as expected. |
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsESLint disabled in files
ESLint disabled line counts
References to deprecated APIs
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
Summary
Allow to clone rule in the rule list table
Checklist