Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security solution] remove guided onboarding feature flag #144247

Merged
merged 18 commits into from
Nov 15, 2022
Merged

[Security solution] remove guided onboarding feature flag #144247

merged 18 commits into from
Nov 15, 2022

Conversation

stephmilovic
Copy link
Contributor

@stephmilovic stephmilovic commented Oct 31, 2022 •
edited
Loading

Summary

Removes the feature flag for the guided onboarding tour in security

To be merged after #144160. Make sure we run the Cypress tests after #144160 is merged before merging this

@stephmilovic stephmilovic added release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore v8.6.0 labels Oct 31, 2022
@stephmilovic stephmilovic requested a review from a team as a code owner October 31, 2022 15:19
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@stephmilovic stephmilovic changed the title remove guided onboarding feature flag [Security solution] remove guided onboarding feature flag Oct 31, 2022
@yuliacech
Copy link
Contributor

@elasticmachine merge upstream

@yuliacech
Copy link
Contributor

Hey @stephmilovic, a fix for the API requests has been merged, I hope this will fix the cypress tests in the security solution.

@yuliacech
Copy link
Contributor

Sorry, there was a revert of my PR, the fix is now in #144459

@yuliacech
Copy link
Contributor

@elasticmachine merge upstream

@stephmilovic
Copy link
Contributor Author

Same failures here where feature flag is off so i think unrelated? #144249 (comment)

ran the failing cypress tests locally on both branches with no issues

@stephmilovic
Copy link
Contributor Author

@elasticmachine merge upstream

@stephmilovic
Copy link
Contributor Author

@elasticmachine merge upstream

@stephmilovic
Copy link
Contributor Author

@elasticmachine merge upstream

@stephmilovic
Copy link
Contributor Author

@elasticmachine merge upstream

@stephmilovic
Copy link
Contributor Author

@yuliacech we're still seeing this call 27 times, causing the same test latency:
image

@yuliacech
Copy link
Contributor

Hey @stephmilovic, I opened a PR that will hopefully fix the issue with the API requests.

@yuliacech
Copy link
Contributor

My PR is merged, updating this branch to fetch the changes.

@stephmilovic stephmilovic requested a review from a team as a code owner November 10, 2022 16:08
@stephmilovic
Copy link
Contributor Author

merge upstream after #144634 is merged

@stephmilovic stephmilovic added ci:cloud-deploy Create or update a Cloud deployment ci:build-example-plugins ci:cloud-persist-deployment Persist cloud deployment indefinitely labels Nov 10, 2022
@stephmilovic
Copy link
Contributor Author

@elasticmachine merge upstream

@stephmilovic
Copy link
Contributor Author

@elasticmachine merge upstream

@stephmilovic
Copy link
Contributor Author

@elasticmachine merge upstream

@stephmilovic stephmilovic enabled auto-merge (squash) November 15, 2022 00:01
@stephmilovic
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

kibana-ci commented Nov 15, 2022 •
edited
Loading

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 9.6MB 9.6MB -48.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 51.0KB 51.0KB -20.0B
Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 59 65 +6
osquery 108 113 +5
securitySolution 441 447 +6
total +19

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 67 73 +6
osquery 109 115 +6
securitySolution 518 524 +6
total +20

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @stephmilovic

@stephmilovic stephmilovic merged commit c4304dc into elastic:main Nov 15, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Nov 15, 2022
jloleysens added a commit to jloleysens/kibana that referenced this pull request Nov 15, 2022
@jloleysens
Merge branch 'main' into files-management
6c5fb8a 
* main: (65 commits)
  Migrate server-side `Root` and `Server` to packages (elastic#144990)
  [Discover] Handle no data views state for `esQuery` alert (elastic#145052)
  [ML] Allow updates for number of allocations and priority for trained model deployments (elastic#144704)
  [api-docs] 2022-11-15 Daily api_docs build (elastic#145203)
  [Security solution] remove guided onboarding feature flag (elastic#144247)
  [DOCS] Automate final case APIs (elastic#145007)
  [Enterprise Search] Name and description flyout for connectors (elastic#143827)
  [Guided onboarding] Update header button logic (elastic#144634)
  [Lens] Multi metric partition charts (elastic#143966)
  [Dashboard] [Controls] Add unmapped runtime field support to options list (elastic#144947)
  [Security Solution] Add Task Metric Collection to New Tasks (elastic#145181)
  [TriggersActionsUi] disable jest config in CI (elastic#145186)
  [TableListView] Enhance tag filtering (elastic#142108)
  [Cloud Posture] Compliance by CIS section table (elastic#145114)
  [8.6][Session View] Fix hidden alert flyout  in session view (elastic#145141)
  [customIntegrations] async load all components (elastic#145166)
  Fix time for logs smoke tests in integration test (elastic#145130)
  [RAM] Update rule status (elastic#140882)
  Update babel (main) (elastic#145060)
  [Actionable Observability] Add context.alertDetailsUrl variable to action connector template for APM rule types (elastic#144791)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamster10 jamster10 jamster10 approved these changes

Assignees

@stephmilovic stephmilovic

Labels
backport:skip This commit does not require backporting ci:build-example-plugins ci:cloud-deploy Create or update a Cloud deployment ci:cloud-persist-deployment Persist cloud deployment indefinitely release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@stephmilovic @elasticmachine @yuliacech @kibana-ci @jamster10 @kibanamachine