[Tines connector] SubActions framework changes

[semd]

Summary

Issue: #140066

This PR is part of the Tines connector implementation, which is being implemented using the SubActions framework.
It needed some changes in the SubAction framework in order to meet the requirements, these changes have been extracted into this PR to be reviewed independently, the connector implementation itself is not included.

The SubActions framework changes are:

Backend:

• Some Type generics were created and exported.
• The subAction connector config now accepts renderParameterTemplates to allow custom body rendering.

Frontend:

• useSubAction hook was improved to prevent an infinite request loop.
• Abort control added.
• Action execution response types improved.

[elasticmachine]

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

[cnasikas]

Thank you for the fixes!

[semd]

@elasticmachine merge upstream

[pmuellr]

LGTM, but added a note about a missing test for the newly supported renderParameterTemplates parameter

[pmuellr]

Seems like we should have a test for this new parameter being copied in, in register.test.ts.

[cnasikas]

nit: This check does not assert that the correct function is passed. What about

const renderParameterTemplates = jest.fn()

const connector = {
    id: '.test',
    name: 'Test',
    minimumLicenseRequired: 'basic' as const,
    supportedFeatureIds: ['alerting'],
    schema: {
      config: TestConfigSchema,
      secrets: TestSecretsSchema,
    },
    Service: TestSubActionConnector,
   renderParameterTemplates,
  };

// code omitted for brevity

 expect(actionTypeRegistry.register).toHaveBeenCalledWith({
      id: connector.id,
      name: connector.name,
      minimumLicenseRequired: connector.minimumLicenseRequired,
      supportedFeatureIds: connector.supportedFeatureIds,
      validate: expect.anything(),
      executor: expect.anything(),
      renderParameterTemplates,
    }); 

[semd]

Sure, I was following the same criteria as in the validate and executor properties.
However, strictly speaking, it does not need to be the same function, the important thing is the function is properly wired.
Instead of testing the function reference (it could change and still be correct), I updated the test by adding a test case that checks the renderParameterTemplates is called with the correct parameters and it returns the correct value.

[cnasikas]

You are right @semd! We should improve that. Thanks for the additional test. Much better.

[semd]

@cnasikas 👍 thanks for the review!

[elasticmachine]

Pinging @elastic/response-ops (Team:ResponseOps)

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: 750df0b

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
actions	211	208	-3

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
actions	21	23	+2

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
triggersActionsUi	99.1KB	99.1KB	+18.0B

Unknown metric groups

API count

id	before	after	diff
actions	216	213	-3

History

• 💚 Build #78307 succeeded 9f6d376
• 💚 Build #78237 succeeded 0d3a286
• 💚 Build #78013 succeeded 93f01b8
• 💚 Build #77948 succeeded d713c4a
• 💔 Build #77867 failed e060abe
• 💔 Build #77834 failed a06f6cb

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @semd