[Cases] Fix jira_params.test.tsx flaky test
#141574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnasikas
added
release_note:skip
|
Pinging @elastic/response-ops (Team:ResponseOps) |
|
Pinging @elastic/response-ops-cases (Feature:Cases) |
cnasikas
commented
Sep 23, 2022
| @@ -196,191 +196,188 @@ const JiraParamsFields: React.FunctionComponent<ActionParamsProps<JiraActionPara | |||
|
|
|||
| return ( | |||
| <> | |||
| <EuiFormRow | |||
There was a problem hiding this comment.
This is not as bad as it looks. I remove an extra <></>. Please review with "Hide whitespace" enabled.
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @cnasikas |
jonathan-buttner
approved these changes
Sep 23, 2022
cnasikas
added
backport:prev-minor
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 23, 2022
* Fix flaky test * Fix typo (cherry picked from commit 4c16e62)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 23, 2022
* Fix flaky test * Fix typo (cherry picked from commit 4c16e62) Co-authored-by: Christos Nasikas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is an attempt to fix the flakiness of the
x-pack/plugins/triggers_actions_ui/public/application/components/builtin_action_types/jira/jira_params.test.tsxflaky test.I did the following:
actwaitForwhen neededI run the test locally 1000 times without issues.
Context: #139062
Checklist
Delete any items that are not applicable to this PR.
For maintainers