[ML] Removing global ml exhaustive-deps rule #139907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
jgowdyelastic
added
non-issue
|
Pinging @elastic/ml-ui (:ml) |
darnautov
approved these changes
Sep 6, 2022
kibanamachine
added
v8.5.0
backport:skip
Mpdreamz
pushed a commit
to Mpdreamz/kibana
that referenced
this pull request
Sep 6, 2022
* [ML] Removing global ml exhaustive-deps rule * changes after main merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the global eslint exhaustive-deps rule suppression and adds inline comments to suppress every violation.
This will stop any future code from breaking this rule by accident.
We can then divide the work between us to remove these comments and fix the dependencies.
It's worth noting that I purposely didn't auto fix these rule breakages as previous attempts at doing that caused a lot of problems. Mainly due to incorrect hook usage.
We could auto fix them in a more focused approach, perhaps a page at a time, to ensure no functional problems.
Fixes #49565