Migrate server-side deprecation service to packages
#139789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgayvallet
added
Team:Core
pgayvallet
commented
Aug 31, 2022
Comment on lines
+9
to
+10
| export { mockDeprecationsRegistry } from './deprecations_registry.mock'; | ||
| export { mockDeprecationsFactory } from './deprecations_factory.mock'; |
There was a problem hiding this comment.
These two mocks were only used for internal testing. There is no code duplication involved this time.
…ide-deprecation-to-packages
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Unknown metric groupsAPI count
ESLint disabled in files
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
|
Pinging @elastic/kibana-core (Team:Core) |
gsoldevila
reviewed
Aug 31, 2022
Mpdreamz
pushed a commit
to Mpdreamz/kibana
that referenced
this pull request
Sep 6, 2022
* Move files to packages * start fixing usages * [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix' * fix more usages * move mdx files * update READMEs * add author to package files * snake casing Co-authored-by: kibanamachine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #135961
#139305 already handled moving most of the public types
This PR creates the following packages:
@kbn/core-deprecations-server-internal@kbn/core-deprecations-server-mocksand move the content of
src/core/server/deprecationsaccordingly.