Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jest/helpers] add safeAct helper to try and debug act() #139444

Closed
wants to merge 18 commits into from
Closed

[jest/helpers] add safeAct helper to try and debug act() #139444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
fe0120e
[jest/helpers] add safeAct helper to try and debug act()
Aug 24, 2022
8c3d953
use safeAct in ilm jest tests
Aug 24, 2022
eadc8c2
remove invalid use of act()
Aug 24, 2022
899bf82
only run unit tests for now
Aug 25, 2022
8ee08c1
remove act in afterAll()
Aug 25, 2022
01b76cb
fail safeAct more aggressively
Aug 25, 2022
e9a4335
just run ILM tests over and over
Aug 25, 2022
3e1e26e
disable build too
Aug 25, 2022
637b09e
remove metric failure reporting
Aug 25, 2022
51dd25b
run jest a lot more times in a single build
Aug 25, 2022
cebe5a5
hard-code jest configs
Aug 25, 2022
3d6b9b1
ensure that safeAct() violations are actually logged
Aug 25, 2022
35f634c
patch react-dom/test-utils for better debugging
Aug 30, 2022
d7dec5f
Merge branch 'main' of github.com:elastic/kibana into implement/safe-act
Aug 30, 2022
0447cec
fix import
Aug 30, 2022
fc84968
exit early on failure
Aug 30, 2022
0de0f07
switch back to default act helper
Aug 31, 2022
c397beb
Merge branch 'main' of github.com:elastic/kibana into implement/safe-act
Aug 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .buildkite/pipeline-utils/buildkite/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ export interface BuildkiteStep {
command: string;
label: string;
parallelism?: number;
concurrency?: number;
concurrency_group?: string;
agents: {
queue: string;
};
Expand Down
18 changes: 0 additions & 18 deletions .buildkite/pipeline-utils/ci-stats/on_complete.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,22 +21,4 @@ export async function onComplete() {
const status = result.success ? 'SUCCESS' : 'FAILURE';
console.log('Job Status:', result);
await ciStats.completeBuild(status, process.env.CI_STATS_BUILD_ID);

if (!process.env.GITHUB_PR_NUMBER) {
return;
}

const report = await ciStats.getPrReport(process.env.CI_STATS_BUILD_ID);
if (report?.md) {
buildkite.setMetadata('pr_comment:ci_stats_report:body', report.md);

const annotationType = report?.success ? 'info' : 'error';
buildkite.setAnnotation('ci-stats-report', annotationType, report.md);
}

if (report && !report.success) {
console.log('+++ CI Stats Report');
console.error('Failing build due to CI Stats report. See annotation at top of build.');
process.exit(1);
}
}
Loading