-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution][Detections] fixes setting timeline to None on bulk edit #137836
[Security Solution][Detections] fixes setting timeline to None on bulk edit #137836
Conversation
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
Page load bundle
To update your PR or re-run it, just comment with: |
@@ -7,7 +7,7 @@ | |||
|
|||
import type { AlertEvent, ResolverNode, SafeResolverEvent } from '../../../common/endpoint/types'; | |||
|
|||
type BaseSearchTypes = string | number | boolean | object; | |||
type BaseSearchTypes = string | number | boolean | object | null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
making timelineId and timelineTitle nullable requires changes in this typing as well
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
Pinging @elastic/security-solution (Team: SecuritySolution) |
After #137593 is merged, we don't need this one anymore at this time. |
Summary
None
, timeline_id and timeline_title will be set tonull
on bulk edit action (this fixes issue when ruilesClient.bulkEdit can't remove fields from rules, so instead, we set these fields tonull
)Checklist
Delete any items that are not applicable to this PR.
For maintainers