Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution][Detections] fixes setting timeline to None on bulk edit #137836

Closed

Conversation

vitaliidm
Copy link
Contributor

@vitaliidm vitaliidm commented Aug 2, 2022

Summary

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 5.6MB 5.6MB -2.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 254.1KB 254.2KB +36.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@vitaliidm vitaliidm self-assigned this Aug 2, 2022
@vitaliidm vitaliidm added Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Feature:Rule Management Security Solution Detection Rule Management area Team:Detection Rule Management Security Detection Rule Management Team v8.4.0 backport backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) bug Fixes for quality problems that affect the customer experience labels Aug 2, 2022
@@ -7,7 +7,7 @@

import type { AlertEvent, ResolverNode, SafeResolverEvent } from '../../../common/endpoint/types';

type BaseSearchTypes = string | number | boolean | object;
type BaseSearchTypes = string | number | boolean | object | null;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

making timelineId and timelineTitle nullable requires changes in this typing as well

@vitaliidm vitaliidm marked this pull request as ready for review August 2, 2022 17:24
@vitaliidm vitaliidm requested review from a team as code owners August 2, 2022 17:24
@vitaliidm vitaliidm requested a review from jpdjere August 2, 2022 17:24
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@vitaliidm vitaliidm requested review from banderror and removed request for jpdjere August 2, 2022 17:25
@vitaliidm
Copy link
Contributor Author

After #137593 is merged, we don't need this one anymore at this time.
If we still consider making timeline_title/timeline_id nullable, PR can be reopened and re-worked

@vitaliidm vitaliidm closed this Aug 3, 2022
@vitaliidm vitaliidm deleted the security-solution/fix-timeline-none branch March 4, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) backport bug Fixes for quality problems that affect the customer experience Feature:Rule Management Security Solution Detection Rule Management area Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.4.0
Projects
None yet
3 participants