[artifacts] Improve cloud deployment error handling #137775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbudz
added
Team:Operations
jbudz
force-pushed
the
artifacts/exit-status
branch
from
08b6a37 to
a5ee12b
Compare
jbudz
added
ci:skip-when-possible
|
Pinging @elastic/kibana-operations (Team:Operations) |
jbudz
added
the
backport:prev-minor
spalger
reviewed
Sep 1, 2022
brianseeders
reviewed
Sep 1, 2022
.buildkite/pipelines/artifacts.yml
Outdated
| agents: | ||
| queue: n2-2 | ||
| timeout_in_minutes: 30 | ||
| if: "build.env('RELEASE_BUILD') == null || build.env('RELEASE_BUILD') == '' || build.env('RELEASE_BUILD') == 'false'" | ||
| retry: | ||
| automatic: | ||
| # Matches buildkite forced agent shutdown (timeout_in_minutes) and ecctl create failures |
There was a problem hiding this comment.
Note that you'll only get a 255 if the job times out AND the job gracefully stops. If the job has to be hard-killed because it's taking too long to exit after the timeout, you'll get a -1.
There was a problem hiding this comment.
Hmm, -1 could also be a pre-emption hard-kill too right?
There was a problem hiding this comment.
Yep, anything where the job or agent shuts down not gracefully. Problem with the GCP instance, OOM kill, etc
There was a problem hiding this comment.
oh this isn't using spot instances
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
jbudz
added a commit
that referenced
this pull request
Sep 6, 2022
* [artifacts] Improve cloud deployment error handling * Update .buildkite/scripts/steps/artifacts/cloud.sh Co-authored-by: Spencer <[email protected]> * update retry codes Co-authored-by: Spencer <[email protected]>
jbudz
added a commit
that referenced
this pull request
Sep 6, 2022
* [artifacts] Improve cloud deployment error handling * Update .buildkite/scripts/steps/artifacts/cloud.sh Co-authored-by: Spencer <[email protected]> * update retry codes Co-authored-by: Spencer <[email protected]> Co-authored-by: Spencer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates Cloud tests to:
I plan on following up with updating slack notifications to distinguish a soft failure. Open to ideas on how to improve the UX further.
Failure: https://buildkite.com/elastic/kibana-artifacts-snapshot/builds/574
Success: https://buildkite.com/elastic/kibana-artifacts-snapshot/builds/575