Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] Add reinstall button to integration settings page #135590

Merged
merged 4 commits into from
Jul 11, 2022
Merged

[Fleet] Add reinstall button to integration settings page #135590

merged 4 commits into from
Jul 11, 2022

Conversation

jen-huang
Copy link
Contributor

@jen-huang jen-huang commented Jun 30, 2022 •
edited
Loading

Summary

Resolves #129318. This PR adds a reinstall button:

Jun-30-2022 11-40-58

Docs request in elastic/observability-docs#1972

@jen-huang jen-huang added release_note:enhancement Team:Fleet Team label for Observability Data Collection Fleet team v8.4.0 labels Jun 30, 2022
@jen-huang jen-huang requested a review from a team as a code owner June 30, 2022 18:42
@jen-huang jen-huang self-assigned this Jun 30, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@jen-huang jen-huang mentioned this pull request Jun 30, 2022
Closed
@nchaulet nchaulet self-requested a review June 30, 2022 18:48
nchaulet
nchaulet reviewed Jun 30, 2022
View reviewed changes
x-pack/plugins/fleet/public/applications/integrations/hooks/use_package_install.tsx
@@ -66,12 +67,22 @@ function usePackageInstall({
);

const installPackage = useCallback(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am wondering if that PR could be a good candidate to start a unit test for that hook?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I attempted to start some unit tests for this hook, but the composition is unique in our codebase (uses createContainer) and I wasn't able to quickly add tests. I opened #136155 as a tech debt item to unblock this from going in.

nchaulet
nchaulet approved these changes Jun 30, 2022
View reviewed changes
Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it works as expected 🚀 just one suggestion to add some test to the usePackageInstall hook

@juliaElastic
Copy link
Contributor

@elasticmachine merge upstream

@jen-huang
Copy link
Contributor Author

@elasticmachine merge upstream

@jen-huang jen-huang mentioned this pull request Jul 11, 2022
Open
@jen-huang jen-huang enabled auto-merge (squash) July 11, 2022 21:22
@jen-huang jen-huang added the auto-backport Deprecated - use backport:version if exact versions are needed label Jul 11, 2022
@jen-huang jen-huang merged commit e817d5e into elastic:main Jul 11, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
fleet 738 739 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 847.1KB 849.0KB +1.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
fleet 111.6KB 111.7KB +50.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jen-huang

@jen-huang jen-huang deleted the enhance/pkg-reinstall branch July 11, 2022 21:53
kibanamachine pushed a commit that referenced this pull request Jul 11, 2022
@jen-huang
[Fleet] Add reinstall button to integration settings page (#135590)
2245e21 
* Add package reinstall button in settings tab

* Fix uninstall unavailable message

Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit e817d5e)
@kibanamachine kibanamachine mentioned this pull request Jul 11, 2022
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.3

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jul 11, 2022
@kibanamachine @jen-huang
[Fleet] Add reinstall button to integration settings page (#135590) (#…
a2f538d 
…136158)

* Add package reinstall button in settings tab

* Fix uninstall unavailable message

Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit e817d5e)

Co-authored-by: Jen Huang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nchaulet nchaulet nchaulet approved these changes

Assignees

@jen-huang jen-huang

Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:fix Team:Fleet Team label for Observability Data Collection Fleet team v8.3.3 v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Fleet] Add a package reinstall / reset button
6 participants
@jen-huang @elasticmachine @juliaElastic @kibana-ci @kibanamachine @nchaulet