-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Canvas][A11y] Adds an H1 tag with the workpad title when viewing workpads #135504
Conversation
Pinging @elastic/kibana-presentation (Team:Presentation) |
Pinging @elastic/kibana-accessibility (Project:Accessibility) |
…-ref HEAD~1..HEAD --fix'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally with screen reader on and off. Ensured that the h1
tag updated as the title was changed, and verified that the focus()
on mount impacted behaviour as expected.
Left one simple clarifying question and another about confirming whether or not focus
ing on the h1
tag is the right move from an a11y stand point, but otherwise, works great 👍
x-pack/plugins/canvas/public/components/workpad_app/workpad_app.component.tsx
Show resolved
Hide resolved
@elasticmachine merge upstream |
… into canvas/a11y-h1-title
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me - briefly tested plus code review 👍 Left one tiny nit but otherwise looks great
x-pack/plugins/canvas/public/components/workpad_app/workpad_app.component.tsx
Show resolved
Hide resolved
… into canvas/a11y-h1-title
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
Summary
Related to #61870.
Closes #25494.
This adds an H1 tag with the workpad title for screen readers only and focuses on the title when navigating to this workpad editor page.
I also noticed some strange behavior when you delete your workpad title with the document title and the breadcrumbs, so I made both fallback to displaying the workpad ID when the title is an empty string.
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers