[UI Framework] [K7] Add KuiButtonEmpty #13540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge, and form control components.
cjcenizal
added
the
Team:Platform-Design
snide
approved these changes
Aug 16, 2017
cjcenizal
added a commit
to cjcenizal/kibana
that referenced
this pull request
Aug 26, 2017
* Make icon-specification props consistent throughout KuiButton, KuiBadge, and form control components. * Create KuiButtonOption. Refine KuiButton disabled state. * Change name to KuiButtonEmpty.
cjcenizal
added a commit
that referenced
this pull request
Sep 19, 2017
* Make icon-specification props consistent throughout KuiButton, KuiBadge, and form control components. * Create KuiButtonOption. Refine KuiButton disabled state. * Change name to KuiButtonEmpty.
cjcenizal
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's still some minor duplication between KuiButton and KuiButtonOption (suggestions for a better name are welcome!), but I think the code is in a state where we can refactor it later without changing the way these components are used.