Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to allow a license for a particular package #135336

Merged

Conversation

hop-dev
Copy link
Contributor

@hop-dev hop-dev commented Jun 28, 2022

Summary

Related to #133822.

Allow named packages to have licenses that are not in the allowed list of licenses.

In #135223 we will be adding an LGPLv3 licensed module, my only option was to add this to the global allow list. However @jbudz raised thta we should only allow this license on a per-package basis, which this PR addresses.

@hop-dev hop-dev self-assigned this Jun 28, 2022
@hop-dev hop-dev added Team:Operations Team label for Operations Team release_note:skip Skip the PR/issue when compiling release notes v8.4.0 labels Jun 28, 2022
@hop-dev hop-dev marked this pull request as ready for review June 28, 2022 15:40
@hop-dev hop-dev requested a review from a team as a code owner June 28, 2022 15:40
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@hop-dev hop-dev enabled auto-merge (squash) June 28, 2022 16:36
@hop-dev hop-dev merged commit 7955dc4 into elastic:main Jun 28, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @hop-dev

@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jun 28, 2022
@hop-dev hop-dev deleted the 133822-allow-per-package-license-overrides branch June 28, 2022 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v8.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants