Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Add fetch package unit tests #134768

Merged
merged 6 commits into from
Jun 20, 2022

Conversation

hop-dev
Copy link
Contributor

@hop-dev hop-dev commented Jun 20, 2022

Summary

Resolves #127167.

Add unit tests for fetch package behaviour and edge cases.

@hop-dev hop-dev added release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.4.0 labels Jun 20, 2022
@hop-dev hop-dev self-assigned this Jun 20, 2022
@hop-dev hop-dev force-pushed the 127167-registry-fetch-unit-tests branch from 1b7b0ad to b97ff50 Compare June 20, 2022 18:29
@@ -0,0 +1,89 @@
/*
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these tests haven't been changed, only moved to be next to the code they test

@hop-dev hop-dev marked this pull request as ready for review June 20, 2022 18:31
@hop-dev hop-dev requested a review from a team as a code owner June 20, 2022 18:31
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

Copy link
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these!

@hop-dev hop-dev enabled auto-merge (squash) June 20, 2022 19:00
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

  • 💚 Build #51920 succeeded 1b7b0adae61f82825e3bfe2697df3f491f0e8261

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @hop-dev

@hop-dev hop-dev merged commit 7cbd0bf into elastic:main Jun 20, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fleet] Add unit tests for fetch with Registry and package installation
5 participants