Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] removed requireAllSpaces from integration privilege #131902

Merged
merged 4 commits into from
May 18, 2022
Merged

[Fleet] removed requireAllSpaces from integration privilege #131902

merged 4 commits into from
May 18, 2022

Conversation

juliaElastic
Copy link
Contributor

Summary

Fixes #130554

I have a doubt which I asked here #130554 (comment)

With this change Integrations privilege is allowed to be added to any space for BWC

image

@juliaElastic juliaElastic added release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v8.3.0 v8.2.1 v8.1.4 labels May 10, 2022
@juliaElastic juliaElastic requested a review from a team as a code owner May 10, 2022 11:38
@juliaElastic juliaElastic self-assigned this May 10, 2022
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label May 10, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

kpollich
kpollich approved these changes May 10, 2022
View reviewed changes
Copy link
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change LGTM.

@juliaElastic
Copy link
Contributor Author

@elasticmachine merge upstream

@joshdover joshdover self-assigned this May 18, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @joshdover @juliaElastic

@joshdover joshdover merged commit eb29e7a into elastic:main May 18, 2022
kibanamachine pushed a commit that referenced this pull request May 18, 2022
@juliaElastic
[Fleet] removed requireAllSpaces from integration privilege (#131902)
069c912 
Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Josh Dover <[email protected]>
(cherry picked from commit eb29e7a)
@kibanamachine kibanamachine mentioned this pull request May 18, 2022
Merged
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
✅ 8.2
❌ 8.1 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 131902

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request May 18, 2022
@kibanamachine @juliaElastic
[Fleet] removed requireAllSpaces from integration privilege (#131902) (…
6294107 
…#132420)

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Josh Dover <[email protected]>
(cherry picked from commit eb29e7a)

Co-authored-by: Julia Bardi <[email protected]>
@juliaElastic juliaElastic mentioned this pull request May 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpollich kpollich kpollich approved these changes

Assignees

@joshdover joshdover

@juliaElastic juliaElastic

Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.2.1 v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Roles with legacy "Fleet and Integrations" privilege are malformed
6 participants
@juliaElastic @elasticmachine @kibana-ci @kibanamachine @kpollich @joshdover